Add MAGE_RUN_TYPE+MAGE_RUN_CODE to FPC identifier #18624

amenk · 2018-10-15T14:00:20Z

Description

Currently Magento 2.2.6 full page cache does not work correctly, when using SetEnv or similar techniques on unchanged URLs

So the MAGE_RUN_TYPE and MAGE_RUN_CODE should be added to the FPC identifier to allow for such use cases.

A common case is Magento 2 behind a reverse NGINX proxy.

Manual testing scenarios

Steps to reproduce, without proxy setup:

In pub/.htaccess set

SetEnv MAGE_RUN_TYPE store SetEnv MAGE_RUN_CODE italy

Now open Frontend
Now set

SetEnv MAGE_RUN_TYPE store SetEnv MAGE_RUN_CODE english

Now Open frontend, same URL

-> Italian version is displayed

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-cicd2 · 2018-10-15T14:00:23Z

All committers have signed the CLA.

magento-engcom-team · 2018-10-15T14:00:26Z

Hi @amenk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

miguelbalparda · 2018-10-16T17:22:20Z

Hi @amenk, can you please check the failing tests?

amenk · 2018-10-16T19:36:53Z

@miguelbalparda

Okay I will..probably I should also add a new test as well.
Is the code fine, or is the approach wrong?

I was afraid using mage store constants in framework but it seems to happen also in other places.

miguelbalparda · 2018-10-19T12:14:43Z

I think the approach is correct, will double check internally and get back to you if anything changes.

miguelbalparda · 2018-11-19T11:53:01Z

Anything on this one @amenk? It's been a while, please let me know if you are still working on this PR.

amenk · 2018-11-19T11:59:40Z

I think the approach is correct, will double check internally and get back to you if anything changes.

@miguelbalparda I was waiting for your response on this ...

and I am having a lack of time, but will try my best to get that PR through, if you tell me, the approach is correct.

miguelbalparda · 2018-12-18T16:25:08Z

Closing for lack of feedback, feel free to reopen if you have time to keep working on this,

amenk · 2018-12-18T17:15:00Z

@miguelbalparda

will double check internally and get back to you if anything changes.

Did you already double check?

amenk · 2018-12-31T12:03:56Z

@miguelbalparda your feedback would motivate me :-)

I am still not sure if my approach has scoping issues ...

amenk · 2019-03-08T09:29:23Z

Will work on this today.

…reak

…ontinue"

…with BC break

Needs to be called from LinkProcessor

sivaschenko · 2019-06-11T20:10:59Z

@amenk thanks for your patience, this pull request is under discussion

sivaschenko · 2019-06-11T20:11:24Z

@magento run all tests

Currently Magento 2.2.6 full page cache does not work correctly, when using SetEnv or similar techniques on unchanged URLs So the MAGE_RUN_TYPE and MAGE_RUN_CODE should be added to the FPC identifier to allow for such use cases. A common case is Magento 2 behind a reverse NGINX proxy. This commit adds the MAGE_RUN_TYPE and MAGE_RUN_CODE to the cache idenfier, if present. It is done inline with the design exceptions. Also the existing cache idenfier is change a little to accomondate the new information properly. Of course this will invalidate existing page caches with design exceptions, but as for any deploy the page cache usually is invalidated, this is not a problem.

ghost · 2019-06-22T14:19:47Z

@amenk unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request

amenk · 2019-06-22T14:21:49Z

@amenk unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request

I did not try to unassign anybody :)

amenk · 2019-06-22T15:17:45Z

all checks are green now

magento-engcom-team · 2019-07-19T11:05:44Z

Hi @sivaschenko, thank you for the review.
ENGCOM-4467 has been created to process this Pull Request
✳️ @sivaschenko, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Delta · 2019-07-22T14:18:44Z

✔️ QA passed

m2-assistant · 2019-08-09T15:41:38Z

Hi @amenk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

…o#18624

magento-engcom-team added the Component: Framework/App label Oct 15, 2018

magento-engcom-team added the Release Line: 2.3 label Oct 15, 2018

miguelbalparda self-assigned this Oct 15, 2018

miguelbalparda closed this Dec 18, 2018

amenk mentioned this pull request Jan 6, 2019

Full page caching issue on multisite #4556

Closed

amenk reopened this Mar 8, 2019

ghost unassigned miguelbalparda Mar 8, 2019

amenk force-pushed the amenk-patch-2 branch 2 times, most recently from 7911630 to c21c44e Compare March 8, 2019 10:54

amenk added a commit to iMi-digital/magento2 that referenced this pull request Mar 8, 2019

magento#18624 Refactoring: Extract addLinks to own class without BC b…

8b73246

…reak

amenk added a commit to iMi-digital/magento2 that referenced this pull request Mar 8, 2019

magento#18624 B/C Break: Move linkNameToId to LinkProcessor

906abf2

amenk added a commit to iMi-digital/magento2 that referenced this pull request Mar 8, 2019

magento#18624 Refactoring: Flattening Conditional tree using early "c…

67bab68

…ontinue"

amenk added a commit to iMi-digital/magento2 that referenced this pull request Mar 8, 2019

magento#18624 Refactoring: Decompose process Funktion; add Changelog …

3a70e41

…with BC break

amenk added a commit to iMi-digital/magento2 that referenced this pull request Mar 9, 2019

magento#18624 Refactoring: Create LinkProcessor via DI

49b62cf

amenk added a commit to iMi-digital/magento2 that referenced this pull request Mar 9, 2019

magento#18624 Refactoring: Extract linkNameToId to di config

f8fcb2e

amenk added a commit to iMi-digital/magento2 that referenced this pull request Mar 9, 2019

magento#18624 Refactoring: Type hinting and remove unused parameter

5be2075

amenk added a commit to iMi-digital/magento2 that referenced this pull request Mar 9, 2019

magento#18624 Refactoring: Extract Database code

28cd9d1

amenk added a commit to iMi-digital/magento2 that referenced this pull request Mar 9, 2019

magento#18624 Refactoring: Extract code

10e68bc

amenk added a commit to iMi-digital/magento2 that referenced this pull request Mar 9, 2019

magento#18624 Refactoring: Bugfix: getExistingSku needs to be public

87f4c35

Needs to be called from LinkProcessor

sivaschenko removed the Progress: needs update label Jun 11, 2019

engcom-Foxtrot assigned engcom-Foxtrot and unassigned p-bystritsky Jun 18, 2019

amenk and others added 3 commits June 22, 2019 16:13

magento#18624: Static test fix.

63c0f53

PHPCSFixes

84a725e

amenk force-pushed the amenk-patch-2 branch from 5e0ff24 to 84a725e Compare June 22, 2019 14:19

amenk unassigned VasylShvorak Jun 22, 2019

ihor-sviziev requested a review from sivaschenko July 19, 2019 06:09

sivaschenko approved these changes Jul 19, 2019

View reviewed changes

ghost added the Progress: ready for testing label Jul 19, 2019

engcom-Delta self-assigned this Jul 19, 2019

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jul 19, 2019

sivaschenko added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Jul 21, 2019

ghost added Progress: extended testing Progress: accept and removed Progress: testing in progress Progress: extended testing labels Jul 22, 2019

magento-engcom-team merged commit 84a725e into magento:2.3-develop Aug 9, 2019

magento-engcom-team added this to the Release: 2.3.4 milestone Aug 9, 2019

taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Aug 9, 2019

ENGCOM-4467: Add MAGE_RUN_TYPE+MAGE_RUN_CODE to FPC identifier magent…

f903902

…o#18624

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add MAGE_RUN_TYPE+MAGE_RUN_CODE to FPC identifier #18624

Add MAGE_RUN_TYPE+MAGE_RUN_CODE to FPC identifier #18624

amenk commented Oct 15, 2018 •

edited by Maikel-Koek

Loading

magento-cicd2 commented Oct 15, 2018 •

edited

Loading

magento-engcom-team commented Oct 15, 2018

miguelbalparda commented Oct 16, 2018

amenk commented Oct 16, 2018

miguelbalparda commented Oct 19, 2018

miguelbalparda commented Nov 19, 2018

amenk commented Nov 19, 2018 •

edited

Loading

miguelbalparda commented Dec 18, 2018

amenk commented Dec 18, 2018

amenk commented Dec 31, 2018

amenk commented Mar 8, 2019

sivaschenko commented Jun 11, 2019

sivaschenko commented Jun 11, 2019

ghost commented Jun 22, 2019

amenk commented Jun 22, 2019

amenk commented Jun 22, 2019

magento-engcom-team commented Jul 19, 2019

engcom-Delta commented Jul 22, 2019

m2-assistant bot commented Aug 9, 2019

Add MAGE_RUN_TYPE+MAGE_RUN_CODE to FPC identifier #18624

Add MAGE_RUN_TYPE+MAGE_RUN_CODE to FPC identifier #18624

Conversation

amenk commented Oct 15, 2018 • edited by Maikel-Koek Loading

Description

Manual testing scenarios

Contribution checklist

magento-cicd2 commented Oct 15, 2018 • edited Loading

magento-engcom-team commented Oct 15, 2018

miguelbalparda commented Oct 16, 2018

amenk commented Oct 16, 2018

miguelbalparda commented Oct 19, 2018

miguelbalparda commented Nov 19, 2018

amenk commented Nov 19, 2018 • edited Loading

miguelbalparda commented Dec 18, 2018

amenk commented Dec 18, 2018

amenk commented Dec 31, 2018

amenk commented Mar 8, 2019

sivaschenko commented Jun 11, 2019

sivaschenko commented Jun 11, 2019

ghost commented Jun 22, 2019

amenk commented Jun 22, 2019

amenk commented Jun 22, 2019

magento-engcom-team commented Jul 19, 2019

engcom-Delta commented Jul 22, 2019

m2-assistant bot commented Aug 9, 2019

amenk commented Oct 15, 2018 •

edited by Maikel-Koek

Loading

magento-cicd2 commented Oct 15, 2018 •

edited

Loading

amenk commented Nov 19, 2018 •

edited

Loading