Fixed Issue: Customer name in admin order management is "Guest" #18640
Conversation
|
Hi @maheshWebkul721. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
#SQUASHTOBERFEST |
mahesh-rajawat
requested review from
rogyar and
rodrigowebjump
and removed request for
rogyar
| } | ||
|
|
||
| $data += ['is_filterable' => 0, 'is_filterable_in_search' => 0]; | ||
|
|
||
| if ($model->getIsUserDefined() === null || $model->getIsUserDefined() != 0) { |
There was a problem hiding this comment.
Could you please tell what is the reason of changes in this file? How is it related to the original issue?
There was a problem hiding this comment.
@slavvka you are right, I cloned my previous fixes and pushed in that so the previous files are also reflecting..... i will update it...
There was a problem hiding this comment.
@maheshWebkul721 Thank you! And please revert all empty lines that you removed.
There was a problem hiding this comment.
@maheshWebkul721 I would suggest you recreated your fix from the scratch and force-pushed it to ensure you don't have not needed changes.
|
@slavvka update the other files which is not relevant to this issue. |
| } | ||
|
|
||
| $data += ['is_filterable' => 0, 'is_filterable_in_search' => 0]; | ||
|
|
||
| if ($model->getIsUserDefined() === null || $model->getIsUserDefined() != 0) { |
There was a problem hiding this comment.
@maheshWebkul721 I would suggest you recreated your fix from the scratch and force-pushed it to ensure you don't have not needed changes.
Fixed Issue of Place an order as an guest, the displayed customer name in the admin order management is "Guest". If the guest has created an account after placing the order, it is a link that points to the customer's account management. Invoice and shipping are also affected.
Description (*)
If Order is placed by Guest user in admin Order view, Invoice view, Shipment view, displaying Customer
name as "Guest", issue was in the quote management, its only set email for the customer, Now i have it
in this pull request.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)