Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #4468 "Unable to insert multiple catalog product list widgets (with pager) in CMS page" #18714

Conversation

vasilii-b
Copy link

Description (*)

This PR aims to solve issue reported in #4468.

Fixed Issues (if relevant)

  1. Unable to insert multiple catalog product list widgets in CMS page #4468: Unable to insert multiple catalog product list widgets in CMS page

2018-10-19_23-31-41

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vasilii-b vasilii-b requested a review from rogyar October 19, 2018 20:43
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: CatalogWidget labels Oct 19, 2018
@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@vasilii-b
Copy link
Author

Hi @rogyar,
I have had a look on the failed unit test and gave it a try on the local as well. The results differ for some reason.

Test results

Travis

image

Local

image


Can you please advice ? Thank you!

@rogyar
Copy link
Contributor

rogyar commented Oct 22, 2018

Hi @vasilii-b. That might be a case when a timestamp is used during the tests and the issue is just a matter of milliseconds/seconds. I will run the tests once again

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 22, 2018
@rogyar
Copy link
Contributor

rogyar commented Oct 23, 2018

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18714-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@rogyar
Copy link
Contributor

rogyar commented Oct 23, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18714//admin
Login: admin Password: 123123q

@magento-engcom-team
Copy link
Contributor

Hi @vasilii-b. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Award: bug fix Component: CatalogWidget Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants