Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent exception when option text converts to false #18720

Merged
merged 1 commit into from
Oct 27, 2018

Conversation

pmclain
Copy link
Contributor

@pmclain pmclain commented Oct 20, 2018

Description (*)

The function would incorrectly through an exception when the option text was
set to a string that would evaluate to false such as "0"

Fixed Issues (if relevant)

  1. OptionManagement.validateOption throws NoSuchEntityException for "0" option label #13083 OptionManagement.validateOption throws NoSuchEntityException for "0" option label

Manual testing scenarios (*)

  1. Create a product attribute of 'dropdown' type via admin page with one option (Admin value: 0, Default Store View value: 0)
  2. Programmatically delete the option using OptionManagement.delete method
  3. The option should be delete w/o any errors

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

The function would incorrectly through an exception when the option text was
set to a string that would evaluate to false such as "0"

Fixes magento#13083
@magento-engcom-team
Copy link
Contributor

Hi @pmclain. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3236 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @pmclain. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants