Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #18655 fixed: Magento 2.3.0-beta18: ReflectionException on Backend -> Stores -> Configuration -> Services -> OAuth page #18750

Conversation

mahesh-rajawat
Copy link
Member

Fixed, Admin Page "Stores -> Configuration -> Services -> OAuth" throws Reflection Exception.

Description (*)

When navigating to Stores -> Configuration -> Services -> OAuth and open this section,
Page displays blank and throws an exception: main.CRITICAL: Class text comment does not exist
I have fixed it in this pull request.

Fixed Issues (if relevant)

  1. Magento 2.3.0-beta18: ReflectionException on Backend -> Stores -> Configuration -> Services -> OAuth page #18655

Manual testing scenarios (*)

  1. After fixed, opens Stores -> Configuration -> Services -> OAuth section, now configurable options
    are visible.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 22, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mahesh-rajawat
Copy link
Member Author

#SQUASHTOBERFEST

@sidolov
Copy link
Contributor

sidolov commented Oct 23, 2018

Hi @maheshWebkul721 , looks like you made some commits with email different than in your GitHub profile, please, add email from commits to your profile!
Thank you!

@mahesh-rajawat
Copy link
Member Author

@sidolov i already added by using this command git config --global user.email "mahesh721@webkul.com"
also i am able to check also it by git config --global user.email and its exists, same email is on my git profile.

@sidolov
Copy link
Contributor

sidolov commented Oct 23, 2018

Hi @maheshWebkul721 , commits 78accc5 was made with the different email, you just need to add this email to your GitHub profile as second and all issues will be resolved

@mahesh-rajawat
Copy link
Member Author

@sidolov email added.

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3353 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants