Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecesary "header" block redeclaration #18772

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Remove unnecesary "header" block redeclaration #18772

merged 2 commits into from
Nov 5, 2018

Conversation

samuel27m
Copy link
Contributor

@samuel27m samuel27m commented Oct 23, 2018 •
edited
Loading

Description (*)

Removed because the "header" block was already created in module Magento_Theme, so this redeclaration is just unnecesary

Fixed Issues (if relevant)

None found on the Magento 2 issues

Manual testing scenarios (*)

  1. Create new module.

  2. Create new default.xml and try to use referenceBlock to set the template. Example:
    <referenceBlock name="header"> <arguments> <argument name="template" xsi:type="string">Samuel27m_Welcome::html/header.phtml</argument> </arguments> </referenceBlock>

  3. Doesn't work, because Luma theme XML files are compiled after all modules and overrides the custom module modifications.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@samuel27m
Remove unnecesary "header" block redeclaration
29ccdae 
Remove unnecesary header block redeclaration on Magento Luma Theme, which made impossible to set the header template through custom modules.

Example: 

- Create new module.
- Create new default.xml and try to use referenceBlock to set the template.
- Doesn't work, because Luma theme XML files are compiled after all modules and overrides the custom module modifications.

Removed because this block was already created in module Magento_Theme, so this redeclaration is just unnecesary
@samuel27m
Merge pull request #1 from samuel27m/samuel27m-patch-1
346d8d5 
Remove unnecesary "header" block redeclaration
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 23, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @samuel27m. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@samuel27m
Copy link
Contributor Author

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @samuel27m. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @samuel27m, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18772//admin
Login: admin Password: 123123q

@samuel27m
Copy link
Contributor Author

samuel27m commented Oct 25, 2018 •
edited
Loading

As you can see on the created instance, "header" block is still there and working fine. This redeclaration of the block for the Luma theme is unnecessary.

@miguelbalparda miguelbalparda self-assigned this Oct 25, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 25, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-3273 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@samuel27m thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@samuel27m
Copy link
Contributor Author

@magento-engcom-team Accepted the invitation. Thanks

@samuel27m
Copy link
Contributor Author

@miguelbalparda We could backport this fix to the 2.2-develop branch, should I do that myself?

@miguelbalparda
Copy link
Contributor

All yours @samuel27m, thanks for the help!!!

@samuel27m samuel27m mentioned this pull request Oct 31, 2018
Merged
4 tasks
@magento-engcom-team magento-engcom-team merged commit 346d8d5 into magento:2.3-develop Nov 5, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 5, 2018
ENGCOM-3273: Remove unnecesary "header" block redeclaration #18772
0beba22
@magento-engcom-team
Copy link
Contributor

Hi @samuel27m. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelbalparda miguelbalparda miguelbalparda approved these changes

Assignees

@miguelbalparda miguelbalparda

Labels
Area: Design/Frontend Component: Theme Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@samuel27m @magento-cicd2 @magento-engcom-team @miguelbalparda