Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless semicolon statements #18788

Merged
merged 1 commit into from
Oct 27, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/;
*/
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ public function rebuildStoreIndex($storeId, $productIds = null)
}
$products = $this->dataProvider
->getSearchableProducts($storeId, $staticFields, $productIds, $lastProductId, $this->batchSize);
};
}
}

/**
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/GiftMessage/Model/ItemRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public function get($cartId, $itemId)
throw new NoSuchEntityException(
__('No item with the provided ID was found in the Cart. Verify the ID and try again.')
);
};
}
$messageId = $item->getGiftMessageId();
if (!$messageId) {
return null;
Expand Down Expand Up @@ -121,7 +121,7 @@ public function save($cartId, \Magento\GiftMessage\Api\Data\MessageInterface $gi
$itemId
)
);
};
}

if ($item->getIsVirtual()) {
throw new InvalidTransitionException(__('Gift messages can\'t be used for virtual products.'));
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/GiftMessage/Model/OrderItemRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function get($orderId, $orderItemId)
throw new NoSuchEntityException(
__('No item with the provided ID was found in the Order. Verify the ID and try again.')
);
};
}

if (!$this->helper->isMessagesAllowed('order_item', $orderItem, $this->storeManager->getStore())) {
throw new NoSuchEntityException(
Expand Down Expand Up @@ -123,7 +123,7 @@ public function save($orderId, $orderItemId, \Magento\GiftMessage\Api\Data\Messa
throw new NoSuchEntityException(
__('No item with the provided ID was found in the Order. Verify the ID and try again.')
);
};
}

if ($order->getIsVirtual()) {
throw new InvalidTransitionException(__("Gift messages can't be used for virtual products."));
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/GiftMessage/Model/OrderRepository.php
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ public function save($orderId, \Magento\GiftMessage\Api\Data\MessageInterface $g
$order = $this->orderFactory->create()->load($orderId);
if (!$order->getEntityId()) {
throw new NoSuchEntityException(__('No order exists with this ID. Verify your information and try again.'));
};
}

if (0 == $order->getTotalItemCount()) {
throw new InputException(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ private function getDependentIndexerIds(string $indexerId)
$this->getDependentIndexerIds($id)
);
}
};
}

return array_unique($dependentIndexerIds);
}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Indexer/Model/DimensionModes.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public function __construct(array $dimensions)
$result = [];
foreach ($dimensions as $dimension) {
$result[$dimension->getName()] = $dimension;
};
}
return $result;
})(...$dimensions);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ private function isStateReadyForInvoice(OrderInterface $order)
$order->getState() === Order::STATE_CLOSED
) {
return false;
};
}

return true;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/;
*/
2 changes: 1 addition & 1 deletion app/code/Magento/Theme/Model/Design/Config/Validator.php
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public function validate(DesignConfigInterface $designConfig)
["templateName" => $name]
)
);
};
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/Theme/view/frontend/templates/text.phtml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ if (!empty($attr)) {
foreach ($block->getAttributes() as $attribute => $value) {
$attributes .= ' ' . $attribute . '="' . $value . '"';
}
};
}
echo
'<' . $block->getTag() . $attributes . '>' . $block->getText() . '</' . $block->getTag() . '>';
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ public function optionDataProvider()
$fixtureOptions[$item['type']] = [
'optionData' => $item,
];
};
}

return $fixtureOptions;
}
Expand Down Expand Up @@ -230,7 +230,7 @@ public function optionNegativeDataProvider()
$fixtureOptions[$key] = [
'optionData' => $item,
];
};
}

return $fixtureOptions;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public function openTab($tabName)
if ($tabHeader->isVisible() && strpos($tabHeader->getAttribute('class'), '_show') === false) {
$tabHeader->hover();
$tabHeader->click();
};
}
return $this;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ private function prepareCsv($csvContent)
$explodedArray = $compiledData['explodedArray'];
} else {
$explodedArray[$i] = str_replace('"', '', $explodedArray[$i]);
};
}
}
$data = array_diff($explodedArray, ['%to_delete%']);
$this->csv[] = $data;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ function rcopy($src, $destination)
// If source is not a directory stop processing
if (!is_dir($src)) {
return false;
};
}

// If the destination directory does not exist create it
// If the destination directory could not be created stop processing
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
if ($product->getId()) {
$product->delete();
}
};
}
$quote->delete();
$registry->unregister('isSecureArea');
$registry->register('isSecureArea', false);
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public function testAcl()
$inheritanceMessage = "Backend controller $className have to inherit " . AbstractAction::class;
$errorMessages[] = $inheritanceMessage;
continue;
};
}

$isAclRedefinedInTheChildClass = $this->isConstantOverwritten($controllerClass)
|| $this->isMethodOverwritten($controllerClass);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public function getIndexerIdsToRunAfter(string $indexerId): array
if (array_search($indexerId, $indexerData['dependencies']) !== false) {
$result[] = $id;
}
};
}

return $result;
}
Expand Down
2 changes: 1 addition & 1 deletion lib/internal/Magento/Framework/Setup/OldDbValidator.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function getNotUpToDateMessage(): string
$requiredVersion = $versionParser->parseConstraints('>' . $error[DbVersionInfo::KEY_REQUIRED]);
if ($requiredVersion->matches($currentVersion)) {
$codebaseUpdateNeeded = true;
};
}

$messages[] = sprintf(
"<info>%20s %10s: %11s -> %-11s</info>",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public function load($className)
include $classSourceFile;
return true;
}
};
}
}

return false;
Expand Down