-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed Product Advanced Pricing design issue #18775 #18790
Conversation
Hi @ashutoshwebkul. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @sidolov, thank you for the review. |
@ashutoshwebkul thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
#squashtoberfest |
Hi @ashutoshwebkul. Thank you for your contribution. |
Description (*)
There was a small design issue die to app/code/Magento/Ui/view/base/web/templates/form/field.html file visible="$data.labelVisible" was on child element of the label, because of that parent was still visible even if the label visibility was false.
Fixed Issues (if relevant)
Manual testing scenarios (*)
3: click on Add Product button
4: fill details then click on Advanced Pricing
5: in customer group price click Add
Contribution checklist (*)