Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Product Advanced Pricing design issue #18775 #18790

Merged
merged 1 commit into from Oct 27, 2018
Merged

fixed Product Advanced Pricing design issue #18775 #18790

merged 1 commit into from Oct 27, 2018

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2018

Description (*)

There was a small design issue die to app/code/Magento/Ui/view/base/web/templates/form/field.html file visible="$data.labelVisible" was on child element of the label, because of that parent was still visible even if the label visibility was false.

Fixed Issues (if relevant)

  1. Product Advanced Pricing design issue #18775: Product Advanced Pricing design issue

Manual testing scenarios (*)

  1. login magento admin
  2. goto catalog products
    3: click on Add Product button
    4: fill details then click on Advanced Pricing
    5: in customer group price click Add

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Sorry, something went wrong.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 24, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @ashutoshwebkul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-3267 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@ashutoshwebkul thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ghost
Copy link
Author

ghost commented Oct 25, 2018

#squashtoberfest

@magento-engcom-team magento-engcom-team merged commit 6bb8258 into magento:2.3-develop Oct 27, 2018
magento-engcom-team pushed a commit that referenced this pull request Oct 27, 2018

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@magento-engcom-team
Copy link
Contributor

Hi @ashutoshwebkul. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants