Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #18150 fixed: Reference Pull Request of #18815 for 2.3-develop #18816

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

mahesh-rajawat
Copy link
Member

Magento_Backup Module Permission issue fixed for Magento 2.3-develop.

Description (*)

If Admin Users assigned a Backup module Role Resource, Still was not able to access
Backups controller. Now its fixed.

Fixed Issues (if relevant)

  1. Backups error from User Roles Permission 2.2.6 #18150
  2. ...

Manual testing scenarios (*)

  1. Created a new Role Settings and assigned custom permission System->Tools.
  2. Logged in via the Sub admin user.
  3. Now Backup Controller is accessible.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mahesh-rajawat
Copy link
Member Author

Reference of #18815 for 2.3-develop

@orlangur orlangur self-assigned this Oct 26, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 26, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3280 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants