Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 18918 Asterisk sign display twice #18922

Merged
merged 6 commits into from
Nov 30, 2018

Conversation

suryakant-krish
Copy link
Contributor

@suryakant-krish suryakant-krish commented Oct 29, 2018

Description (*)

  1. Fixed Asterisk sign display twice.

Fixed Issues (if relevant)

  1. Asterisk sign display twice #18918: Asterisk sign display twice Asterisk sign display twice #18918

Manual testing scenarios (*)

  1. Check screenshot.
    http://prntscr.com/lbpcto
    http://prntscr.com/lbpcl6

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Oct 29, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3324 has been created to process this Pull Request

@VladimirZaets
Copy link
Contributor

Hi @suryakant-krish. We tried to apply your fix, but the problem still reproduces.

@suryakant-krish
Copy link
Contributor Author

Please ignore this commit 7365f5f

I have added new commit c870f0d in this commit issue is fixed.

@suryakant-krish
Copy link
Contributor Author

Can you please check I have commited all my latest changes.

@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants