Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18956 Fixes for set root_category_id #18958

Merged
merged 5 commits into from
Nov 16, 2018
Merged

#18956 Fixes for set root_category_id #18958

merged 5 commits into from
Nov 16, 2018

Conversation

larsroettig
Copy link
Member

@larsroettig larsroettig commented Oct 30, 2018

Description (*)

Currently is not possible to define the root_category_id in the Project config.php

Fixed Issues (if relevant)

  1. Import of RootCategoryId should be possbile (Magento/Store/Model/Config/Importer/Processor/Create.php) #18956 Import of RootCategoryId should be possbile

Manual testing scenarios (*)

  • Create a config.php like
  • Run bin/magento -n app:config:import
    'scopes' => [
        'websites' => [
            'admin' => [
                'website_id' => '0',
                'code' => 'admin',
                'name' => 'Admin',
                'sort_order' => '0',
                'default_group_id' => '0',
                'is_default' => '0'
            ],
            'de' => [
                'website_id' => '2',
                'code' => 'de',
                'name' => 'DE',
                'sort_order' => '10',
                'default_group_id' => '2',
                'is_default' => '1'
            ]
        ],
        'groups' => [
            [
                'group_id' => '0',
                'website_id' => '0',
                'code' => 'default',
                'name' => 'Default',
                'root_category_id' => '0',
                'default_store_id' => '0'
            ],
            [
                'group_id' => '2',
                'website_id' => '2',
                'code' => 'de',
                'name' => 'DE',
                'root_category_id' => '2',
                'default_store_id' => '2'
            ]
        ],
        'stores' => [
            'admin' => [
                'store_id' => '0',
                'code' => 'admin',
                'website_id' => '0',
                'group_id' => '0',
                'name' => 'Admin',
                'sort_order' => '0',
                'is_active' => '1'
            ],
            'de_de' => [
                'store_id' => '2',
                'code' => 'de',
                'website_id' => '2',
                'group_id' => '2',
                'name' => ' de DE',
                'sort_order' => '10',
                'is_active' => '1'
            ]
        ]
    ]

Expected behavior (*)

  • Import of root_category_id is successfully

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @larsroettig. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mhauri mhauri self-requested a review October 30, 2018 20:37
@mhauri mhauri self-assigned this Oct 30, 2018
@larsroettig
Copy link
Member Author

@slavvka i updated this PR

@slavvka
Copy link
Member

slavvka commented Nov 5, 2018

Looks good. I can see the failing Integration job. It failed due a timeout so I restarted it. Could please also take a look on that for the case?

And I also would like to ask you to extend Unit Test to cover new scenario with category_root_id preset.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 7, 2018
@magento-engcom-team
Copy link
Contributor

@larsroettig thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @larsroettig. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

gelanivishal pushed a commit to gelanivishal/magento2 that referenced this pull request Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants