Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default value(y) for confirmation question #18970

Conversation

aheadWorks
Copy link
Contributor

Description (*)

Default value is assumed as "y" for ConfigSetCommand confirmation.

Fixed Issues (if relevant)

  1. 2.3-beta32: DB credentials are not updated in non-interactive mode by bin/magento setup:config:set  #18965: 2.3-beta32: DB credentials are not updated in non-interactive mode by bin/magento setup:config:set

Manual testing scenarios (*)

  1. Set any config value requiring configuration in non-interactive mode with bin/magento setup:config:set -n
  2. Check that value is updated

Contribution checklist (*)

  • [* ] Pull request has a meaningful description of its purpose
  • [*] All commits are accompanied by meaningful commit messages
  • [*] All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 31, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @aheadWorks. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets
Copy link
Contributor

Hi @aheadWorks , please, sign CLA, otherwise, we can't process your pull request

@aheadWorks
Copy link
Contributor Author

@VladimirZaets did it

@VladimirZaets
Copy link
Contributor

@aheadWorks Thanks

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Oct 31, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3346 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@aheadWorks thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team
Copy link
Contributor

Hi @aheadWorks. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants