Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Media Image custom attribute type could not display on frontend. #19054 #19068

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Nov 5, 2018

Description (*)

Using Media Image custom attribute type could not display on frontend. #19054

Fixed Issues (if relevant)

  1. magento/magento2#Using Media Image custom attribute type could not display on frontend.  #19054: Using Media Image custom attribute type could not display on frontend
  2. ...

Manual testing scenarios (*)

  1. Create custom attribute named 'icon_image' of product from admin.
  2. Set attribute type Media Image.
  3. assign icon_image attribute in attribute set.
  4. Update product image and set new role 'icon_image'.
  5. In .phtml template ->
$productImageAttr = $product->getCustomAttribute( 'icon_image' );
$productImage = $this->helper('Magento\Catalog\Helper\Image')
->init($product, 'icon_image')
->setImageFile($productImageAttr->getValue());
<img src="<?php echo $productImage->getUrl() ?>" alt="<?php echo $block->escapeHtml($product->getTitle()) ?>" />

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @Nazar65. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Nazar65
Copy link
Member Author

Nazar65 commented Nov 9, 2018

Hi @miguelbalparda Any updates ?

@Nazar65 Nazar65 requested a review from larsroettig November 12, 2018 09:57
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 21, 2018
@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-3505 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @larsroettig, thank you for the review.
ENGCOM-3505 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @Nazar65. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants