Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18615-Field-restriction-incompatibilities-between-klarna-core-order-a… #19141

Conversation

agorbulin
Copy link

…nd-sales-order-payment-last-trans-id

#18615:Field restriction incompatibilities between klarna_core_order and sales_order_payment last_trans_id

Description (*)

Since column sales_order_payment.last_trans_id has length 32, part of information can be lost.
Increased max length to 255

Fixed Issues (if relevant)

  1. Field restriction incompatibilities between klarna_core_order and sales_order_payment last_trans_id #18615:Field restriction incompatibilities between klarna_core_order and sales_order_payment last_trans_id

Manual testing scenarios (*)

  1. Check column last_trans_id length (should be 255) by SQL request:
    show create table sales_order_payment;
  2. Place order paid by Klarna

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…nd-sales-order-payment-last-trans-id

magento#18615:Field restriction incompatibilities between klarna_core_order and sales_order_payment last_trans_id
@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Component: Sales labels Nov 10, 2018
@magento-engcom-team
Copy link
Contributor

Hi @agorbulin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Nov 10, 2018

Hi @agorbulin. Thank you for your contribution. The corresponding PR has been already created previously and it's in review at the moment.
#18620

@rogyar rogyar closed this Nov 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Sales Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants