Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference PL for #19192 fixed for 2.2-develop #19193

Closed

Conversation

mahesh-rajawat
Copy link
Member

@mahesh-rajawat mahesh-rajawat commented Nov 13, 2018

Incorrect quote_item_id saved on order items during multiple address checkout issue fixed.

Description (*)

When order placed using Multiple address checkout then there were incorrect quote_item_id in
sales_order_item table.

Fixed Issues (if relevant)

  1. Incorrect quote_item_id saved on order items during multiple address checkout #18349

Manual testing scenarios (*)

  1. Placed and Order with Multi address checkout, now quote_item_id is correct.
  2. Placed an order with Onestep checkout quote_item_id is correct as well.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko sivaschenko self-assigned this Nov 19, 2018
@sivaschenko
Copy link
Member

This pull request is a backport of #19192

Copy link
Member

@sivaschenko sivaschenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @maheshWebkul721 can you please add missing commits to this pull request from the 2.3-develop PR (#19192)

@sidolov
Copy link
Contributor

sidolov commented Apr 15, 2019

@maheshWebkul721 , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Apr 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 15, 2019

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants