Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Issue #19205 Fixed: Bundle Product Option with input type is checkbox and add to cart with 3 values only 2 values added to cart. #19316

Closed
wants to merge 2 commits into from

Conversation

torhoehn
Copy link
Contributor

Original Pull Request

#19260

All selections of a bundle option of type check box that were checked once are added to cart -- not all selected values displaying in cart. Now fixed in this PL

Description (*)

While adding Bundle Product having option type checkbox with 3 or more values, and other Bundle option having single value, to the Cart. It was only adding 2 product for first selection. Not its fixed.

Fixed Issues (if relevant)

  1. Bundle Product Option with input type is checkbox and add to cart with 3 values only 2 values added to cart #19205
  2. ...

Manual testing scenarios (*)

  1. Added a product having option type checkbox with 3 or more values, and other Bundle option having single value, to the Cart. Working
  2. Created a new Bundle Product and checked by Adding to the cart.
  3. Run the unit test command for Bundle Module, its also passed

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

We already have #19261. Thanks @torhoehn.

@orlangur orlangur closed this Nov 22, 2018
@torhoehn torhoehn deleted the 2.3-develop-PR-port-19260 branch November 24, 2018 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants