Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] local themes should be added to git repo #19350

Merged
merged 1 commit into from
Nov 29, 2018
Merged

[Forwardport] local themes should be added to git repo #19350

merged 1 commit into from
Nov 29, 2018

Conversation

torhoehn
Copy link
Contributor

Original Pull Request

#18960

Description (*)

Since local-themes.js is always created manually by copying themes.js it should be added to git. So themes.js could also be a .js.dist-file which has to be copied and would be added to git, too.

Fixed Issues (if relevant)

  1. dev/tools/grunt/configs/themes.js gets replaced after update magento #18949: dev/tools/grunt/configs/themes.js gets replaced after update magento

Manual testing scenarios (*)

  1. Copy dev/tools/grunt/configs/themes.js to dev/tools/grunt/configs/local-themes.js
  2. local-themes.js should be found by git now

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: Basecom partners-contribution Pull Request is created by Magento Partner labels Nov 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Nov 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3538 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@torhoehn torhoehn deleted the feature/up-port-pull-18960 branch November 29, 2018 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants