[Forwardport] Fix for Issue #4136, MAGETWO-53440 #19390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 24, 2018 13:15
Added calendar initializaton for Conditional Rules when a rule is created for the 1st time
…acter not preventing from saving - Restricted user to change date input value - Open datepicker popup once user click on the date to be changed
…acter not preventing from saving - Added autocomplete option for calendar.js
magento-engcom-team
added
Partner: Atwix
|
Hi @vasilii-b. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
orlangur
approved these changes
Nov 24, 2018
|
Hi @orlangur, thank you for the review. |
|
Hi @vasilii-b, thank you for your contribution! |
|
Hi @vasilii-b. Thank you for your contribution. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#14485
Description
Full description in #4136.
✔️ Added calendar initialization for Conditional Rules when a rule is created for the 1st time
For the condition type date the datepicker was not initialized when creating new conditions.
This PR aims to solve the issue and do not allow the user to write anything to the input.
Fixed Issues (if relevant)
Issue described in #4136
Manual testing scenarios
Described in #4136
Contribution checklist