Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with Base Currency for website is CND when PayPal Payflow Pro is charging in USD #19430

Merged
merged 1 commit into from
Nov 30, 2018

Conversation

Rykh
Copy link
Contributor

@Rykh Rykh commented Nov 28, 2018

Description (*)

Customers are being billed in USD even though PayPal Payflow Pro is set to use CND. In Magento the order shows CND, but in PayPal the order displays with amounts in USD. The amounts are the same, which means customers are not paying the correctr amount.

Manual testing scenarios (*)

  1. Set Base Currency as USD for default config
  2. Creat Canadian website
  3. Set Base Currency and Default Display Currency for Canadian store to Canadian Dollar.
  4. Go to Canadian store on the store front
  5. Add product to cart
  6. Complete checkout
  7. Invoice the order
  8. Look at different between order details and details shown in PayPal.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 28, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @Rykh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 28, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3583 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@Rykh thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@magento-engcom-team magento-engcom-team merged commit 542120b into magento:2.2-develop Nov 30, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 30, 2018
@magento-engcom-team
Copy link
Contributor

Hi @Rykh. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@diazwatson
Copy link
Contributor

Hey guys, how can I move this to Port to 2.3 Created column?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants