Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed fatal error if upgrading from Magento v2.0.0 to v2.3 and non system attributes missing #19530

Merged
merged 2 commits into from
Apr 16, 2019
Merged

Fixed fatal error if upgrading from Magento v2.0.0 to v2.3 and non system attributes missing #19530

merged 2 commits into from
Apr 16, 2019

Conversation

suneet64
Copy link
Contributor

@suneet64 suneet64 commented Dec 3, 2018 •
edited
Loading

Fixed fatal error if upgrading from Magento v2.0.0 to v2.3 and non system attributes missing.

Description (*)

A fatal error while setup:upgrade if you are upgrading from Magento v2.0.0 to Magento v2.3 and non system attributes not exist in the existing database.

Manual testing scenarios (*)

  1. Have a Magento v2.0.0 clean installation.
  2. Remove manufacturer and color attributes from Stores > Attributes > Product as these are not system attributes.
  3. Upgrade the Magento to v2.3 using command line
  4. Enable the display_errors from app/bootstrap.php file.
  5. Before: Execute setup:upgrade and while upgrading data you will notice a fatal error because of missing manufacturer and color attributes.
    After: The fatal error disappear in this fix.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @suneet64. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@suneet64 suneet64 requested a review from skovalenk December 3, 2018 15:48
@orlangur orlangur self-assigned this Dec 3, 2018
orlangur
orlangur approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @suneet64!

Very similar to https://github.com/magento/magento2/pull/19514/files.

Wondering if we have any other updates.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 3, 2018
@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3609 has been created to process this Pull Request

@suneet64
Copy link
Contributor Author

suneet64 commented Dec 3, 2018

Hi @orlangur ,

I didn't find any other update for this.

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-3609 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@sdzhepa
Copy link
Contributor

sdzhepa commented Mar 28, 2019

✔️ QA passed

@p-bystritsky p-bystritsky self-assigned this Apr 4, 2019
@magento-engcom-team magento-engcom-team merged commit 861fd86 into magento:2.3-develop Apr 16, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2019

Hi @suneet64, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.2 milestone Apr 16, 2019
magento-engcom-team pushed a commit that referenced this pull request Apr 16, 2019
@sidolov
ENGCOM-3609: Fixed fatal error if upgrading from Magento v2.0.0 to v2…
c6d181b 
….3 and non system attributes missing #19530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

@skovalenk skovalenk Awaiting requested review from skovalenk

Assignees

@orlangur orlangur

@p-bystritsky p-bystritsky

Labels
Component: ConfigurableProduct Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
7 participants
@suneet64 @magento-engcom-team @sdzhepa @orlangur @okorshenko @sidolov @p-bystritsky