Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] 18858: Left Side Back End Menu Design fix #19560

Closed

Conversation

suryakant-krish
Copy link
Contributor

@suryakant-krish suryakant-krish commented Dec 5, 2018

Original pull request: #18858

Description (*)

Fixed Left Side Back End Menu Design.

Fixed Issues (if relevant)

  1. Left Side Back End Menu Design fix #18687: Forword Port Left Side Back End Menu Design fix

Manual testing scenarios (*)

  1. Added automatic scroll if the menu item is more.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko sivaschenko self-assigned this Dec 5, 2018
@sivaschenko sivaschenko changed the title Forword port 18858: Left Side Back End Menu Design fix [Forward port] 18858: Left Side Back End Menu Design fix Dec 5, 2018
@sivaschenko sivaschenko changed the title [Forward port] 18858: Left Side Back End Menu Design fix [Forwardport] 18858: Left Side Back End Menu Design fix Dec 5, 2018
@sivaschenko
Copy link
Member

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-19560.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Dec 7, 2018
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3636 has been created to process this Pull Request

@VladimirZaets VladimirZaets self-assigned this Dec 12, 2018
@sivaschenko
Copy link
Member

Hi @suryakant-krish , there is a layout problem found by us while testing, please take a look at the close (cross) button:

image

Could the position of it be adjusted to the corner of the area?

@sidolov
Copy link
Contributor

sidolov commented Jan 15, 2019

Hi @suryakant-krish , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Jan 15, 2019
@ghost
Copy link

ghost commented Jan 15, 2019

Hi @suryakant-krish, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants