Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required interface implementation #1957

Merged
merged 9 commits into from
Aug 12, 2016
Merged

Add required interface implementation #1957

merged 9 commits into from
Aug 12, 2016

Conversation

udovicic
Copy link
Member

Default preference for Magento\Sales\Model\Spi\OrderItemResourceInterface is set to Magento\Sales\Model\Resource\Order\Item, however, given module does not implement required interface.

As a result, OrderItemRepository is not working as described in #1894

@okorshenko okorshenko added the CS label Sep 28, 2015
@magento-cicd2
Copy link
Contributor

We have automated a Magento Contributor License Agreement verifier for contributions sent to our GitHub projects.
Please see the CLA agreement in the Pull Request comments below.

@magento-cicd2 magento-cicd2 reopened this Oct 1, 2015
@NadiyaS NadiyaS self-assigned this Dec 24, 2015
@NadiyaS
Copy link
Contributor

NadiyaS commented May 10, 2016

Hi @udovicic ,
thank you for contribution and we are sorry for delay.
Internal ticket MAGETWO-52645 was created to process your PR.

@NadiyaS NadiyaS added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 10, 2016
@vasiliyseleznev vasiliyseleznev removed the CS label Aug 3, 2016
@vkorotun vkorotun added Component: Sales bugfix and removed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development labels Aug 3, 2016
@sshrewz sshrewz added the linked label Aug 11, 2016
@mmansoor-magento mmansoor-magento merged commit 4821514 into magento:develop Aug 12, 2016
mmansoor-magento pushed a commit that referenced this pull request Aug 12, 2016
@irenelagno
MAGETWO-52645: [GITHUB] Add required interface implementation #1957
4a5f589
@vkorotun vkorotun added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development and removed linked labels Aug 22, 2016
@mbrinton01 mbrinton01 mentioned this pull request Aug 26, 2016
Closed
@udovicic udovicic deleted the bugfix/OrderItemRepository branch October 16, 2016 18:17
magento-team pushed a commit that referenced this pull request Jan 19, 2018
@cpartica
Merge pull request #1957 from magento-obsessive-owls/MAGETWO-86777-ze…
f6d664e 
…nd-mail-bug

[obsessive] MAGETWO-86777: setup:di:compile fatal error for Zend\Mail\Message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@NadiyaS NadiyaS

Labels
bugfix Component: Sales Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@udovicic @magento-cicd2 @NadiyaS @vkublytskyi @vasiliyseleznev @mmansoor-magento @okorshenko @vkorotun @sshrewz