-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed - Lifetime update syntax error #13309 #19634
Fixed - Lifetime update syntax error #13309 #19634
Conversation
Hi @ssp58bleuciel. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssp58bleuciel please squash changes into a single commit and we are good to go.
5387239
to
146f74a
Compare
@orlangur I have squash the changes into a single commit as per your suggestion. |
Hi @orlangur, thank you for the review. |
Hi @ssp58bleuciel. Thank you for your contribution. |
Description (*)
Fixed issue of Lifetime update syntax error
Fixed Issues (if relevant)
Manual testing scenarios (*)
magento2/lib/internal/Magento/Framework/Cache/Backend/Database.php
Line 435
['id=?' => $id, 'expire_time = 0 OR expire_time>' => time()]
Should be (question sign is missing):
['id=?' => $id, 'expire_time = 0 OR expire_time>?' => time()]
Contribution checklist (*)