Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed - Shipping issue on PayPal Express #14712 #19655

Merged

Conversation

nirav-kadiya
Copy link
Contributor

@nirav-kadiya nirav-kadiya commented Dec 8, 2018

Original PR: #19788

Description (*)

Shipping Information is not shown in Summary on PayPal Express Review Page if the Price is 0.00

Fixed Issues (if relevant)

  1. Shipping issue on PayPal Express #14712: Shipping issue on PayPal Express

Manual testing scenarios (*)

  1. Make a Payment using PayPal Express
  2. On the Review Page use a 0.00 Value for a Shipping Method
  3. Summary only shows "Delivery & Handling" but not the Method

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @ssp58bleuciel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

Hi @ssp58bleuciel , thanks for the contribution! Can you please port this pull request to 2.3-develop branch, as it should be merged to 2.3 first.

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Jan 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3997 has been created to process this Pull Request

@ghost
Copy link

ghost commented Jan 31, 2019

Hi @ssp58bleuciel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants