Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] style: change b to strong (a11y) #19668

Merged
merged 2 commits into from Dec 12, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ $fraudDetails = $payment->getAdditionalInformation('fraud_details');
<?php endif; ?>

<?php if(!empty($fraudDetails['fraud_filters'])): ?>
<b><?= $block->escapeHtml(__('Fraud Filters')) ?>:
</b></br>
<strong><?= $block->escapeHtml(__('Fraud Filters')) ?>:
</strong></br>
<?php foreach($fraudDetails['fraud_filters'] as $filter): ?>
<?= $block->escapeHtml($filter['name']) ?>:
<?= $block->escapeHtml($filter['action']) ?>
Expand Down
20 changes: 10 additions & 10 deletions app/code/Magento/Checkout/view/adminhtml/email/failed_payment.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,43 +23,43 @@ <h1>{{trans "Payment Transaction Failed"}}</h1>

<ul>
<li>
<b>{{trans "Reason"}}</b><br />
<strong>{{trans "Reason"}}</strong><br />
{{var reason}}
</li>
<li>
<b>{{trans "Checkout Type"}}</b><br />
<strong>{{trans "Checkout Type"}}</strong><br />
{{var checkoutType}}
</li>
<li>
<b>{{trans "Customer:"}}</b><br />
<strong>{{trans "Customer:"}}</strong><br />
<a href="mailto:{{var customerEmail}}">{{var customer}}</a> &lt;{{var customerEmail}}&gt;
</li>
<li>
<b>{{trans "Items"}}</b><br />
<strong>{{trans "Items"}}</strong><br />
{{var items|raw}}
</li>
<li>
<b>{{trans "Total:"}}</b><br />
<strong>{{trans "Total:"}}</strong><br />
{{var total}}
</li>
<li>
<b>{{trans "Billing Address:"}}</b><br />
<strong>{{trans "Billing Address:"}}</strong><br />
{{var billingAddress.format('html')|raw}}
</li>
<li>
<b>{{trans "Shipping Address:"}}</b><br />
<strong>{{trans "Shipping Address:"}}</strong><br />
{{var shippingAddress.format('html')|raw}}
</li>
<li>
<b>{{trans "Shipping Method:"}}</b><br />
<strong>{{trans "Shipping Method:"}}</strong><br />
{{var shippingMethod}}
</li>
<li>
<b>{{trans "Payment Method:"}}</b><br />
<strong>{{trans "Payment Method:"}}</strong><br />
{{var paymentMethod}}
</li>
<li>
<b>{{trans "Date & Time:"}}</b><br />
<strong>{{trans "Date & Time:"}}</strong><br />
{{var dateAndTime}}
</li>
</ul>
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,19 @@

<table class="message-details">
<tr>
<td><b>{{trans "Name"}}</b></td>
<td><strong>{{trans "Name"}}</strong></td>
<td>{{var data.name}}</td>
</tr>
<tr>
<td><b>{{trans "Email"}}</b></td>
<td><strong>{{trans "Email"}}</strong></td>
<td>{{var data.email}}</td>
</tr>
<tr>
<td><b>{{trans "Phone"}}</b></td>
<td><strong>{{trans "Phone"}}</strong></td>
<td>{{var data.telephone}}</td>
</tr>
</table>
<p><b>{{trans "Message"}}</b></p>
<p><strong>{{trans "Message"}}</strong></p>
<p>{{var data.comment}}</p>

{{template config_path="design/email/footer_template"}}
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ $_rates = ($_newRates) ? $_newRates : $_oldRates;
class="admin__control-text"
<?= ($_currencyCode == $_rate) ? ' disabled' : '' ?> />
<?php if (isset($_newRates) && $_currencyCode != $_rate && isset($_oldRates[$_currencyCode][$_rate])): ?>
<div class="admin__field-note"><?= /* @escapeNotVerified */ __('Old rate:') ?> <b><?= /* @escapeNotVerified */ $_oldRates[$_currencyCode][$_rate] ?></b></div>
<div class="admin__field-note"><?= /* @escapeNotVerified */ __('Old rate:') ?> <strong><?= /* @escapeNotVerified */ $_oldRates[$_currencyCode][$_rate] ?></strong></div>
<?php endif; ?>
</td>
<?php else: ?>
Expand All @@ -56,7 +56,7 @@ $_rates = ($_newRates) ? $_newRates : $_oldRates;
class="admin__control-text"
<?= ($_currencyCode == $_rate) ? ' disabled' : '' ?> />
<?php if (isset($_newRates) && $_currencyCode != $_rate && isset($_oldRates[$_currencyCode][$_rate])): ?>
<div class="admin__field-note"><?= /* @escapeNotVerified */ __('Old rate:') ?> <b><?= /* @escapeNotVerified */ $_oldRates[$_currencyCode][$_rate] ?></b></div>
<div class="admin__field-note"><?= /* @escapeNotVerified */ __('Old rate:') ?> <strong><?= /* @escapeNotVerified */ $_oldRates[$_currencyCode][$_rate] ?></strong></div>
<?php endif; ?>
</td>
<?php endif; ?>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -130,22 +130,22 @@ public function layoutDirectiveDataProvider()
'area parameter - omitted' => [
'adminhtml',
'handle="email_template_test_handle"',
'<b>Email content for frontend/Magento/default theme</b>',
'<strong>Email content for frontend/Magento/default theme</strong>',
],
'area parameter - frontend' => [
'adminhtml',
'handle="email_template_test_handle" area="frontend"',
'<b>Email content for frontend/Magento/default theme</b>',
'<strong>Email content for frontend/Magento/default theme</strong>',
],
'area parameter - backend' => [
'frontend',
'handle="email_template_test_handle" area="adminhtml"',
'<b>Email content for adminhtml/Magento/default theme</b>',
'<strong>Email content for adminhtml/Magento/default theme</strong>',
],
'custom parameter' => [
'frontend',
'handle="email_template_test_handle" template="Magento_Email::sample_email_content_custom.phtml"',
'<b>Custom Email content for frontend/Magento/default theme</b>',
'<strong>Custom Email content for frontend/Magento/default theme</strong>',
],
];
return $result;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -315,25 +315,25 @@ public function templateDirectiveDataProvider()
Area::AREA_FRONTEND,
TemplateTypesInterface::TYPE_HTML,
'{{template config_path="customer/create_account/email_template"}}',
'<b>customer_create_account_email_template template from Vendor/custom_theme</b>',
'<strong>customer_create_account_email_template template from Vendor/custom_theme</strong>',
],
'Template from parent theme - frontend' => [
Area::AREA_FRONTEND,
TemplateTypesInterface::TYPE_HTML,
'{{template config_path="customer/create_account/email_confirmation_template"}}',
'<b>customer_create_account_email_confirmation_template template from Vendor/default</b>',
'<strong>customer_create_account_email_confirmation_template template from Vendor/default</strong',
],
'Template from grandparent theme - frontend' => [
Area::AREA_FRONTEND,
TemplateTypesInterface::TYPE_HTML,
'{{template config_path="customer/create_account/email_confirmed_template"}}',
'<b>customer_create_account_email_confirmed_template template from Magento/default</b>',
'<strong>customer_create_account_email_confirmed_template template from Magento/default</strong',
],
'Template from grandparent theme - adminhtml' => [
BackendFrontNameResolver::AREA_CODE,
TemplateTypesInterface::TYPE_HTML,
'{{template config_path="catalog/productalert_cron/error_email_template"}}',
'<b>catalog_productalert_cron_error_email_template template from Magento/default</b>',
'<strong>catalog_productalert_cron_error_email_template template from Magento/default</strong',
null,
null,
true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
* See COPYING.txt for license details.
*/
?>
<b>Email content for adminhtml/Magento/default theme</b>
<strong>Email content for adminhtml/Magento/default theme</strong>
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
* See COPYING.txt for license details.
*/
-->
<b>catalog_productalert_cron_error_email_template template from Magento/default</b>
<strong>catalog_productalert_cron_error_email_template template from Magento/default</strong>
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
* See COPYING.txt for license details.
*/
-->
<b>customer_create_account_email_confirmed_template template from Magento/default</b>
<strong>customer_create_account_email_confirmed_template template from Magento/default</strong>
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
* See COPYING.txt for license details.
*/
?>
<b>Email content for frontend/Magento/default theme</b>
<strong>Email content for frontend/Magento/default theme</strong>
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
* See COPYING.txt for license details.
*/
?>
<b>Custom Email content for frontend/Magento/default theme</b>
<strong>Custom Email content for frontend/Magento/default theme</strong>
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
* See COPYING.txt for license details.
*/
-->
<b>customer_create_account_email_template template from Vendor/custom_theme</b>
<strong>customer_create_account_email_template template from Vendor/custom_theme</strong>
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
* See COPYING.txt for license details.
*/
-->
<b>customer_create_account_email_confirmation_template template from Vendor/default</b>
<strong>customer_create_account_email_confirmation_template template from Vendor/default</strong>
2 changes: 1 addition & 1 deletion lib/web/css/docs/forms.html
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,7 @@ <h2 id="simple-form-with-required-fields-message">Simple form with &quot;require
<th>@_type</th>
<td class="vars_value">@form-element-input-type</td>
<td class="vars_value">'' [input-text | select | textarea | input-radio | input-checkbox]</td>
<td>Form control type.<br/><b>@form-element-input__[]</b> global variables are used to set up all form elements style. Control-specific global variables use these <b>@form-element-input__[]</b> variables by default. Control-specific global variables can be set up separately.<br/><b>@input-text__[]</b> is used to set up input-text controls style<br/><b>@select__[]</b> is used to set up selects style<br/><b>@textarea__[]</b> is used to set up textarea style</td>
<td>Form control type.<br/><strong>@form-element-input__[]</strong> global variables are used to set up all form elements style. Control-specific global variables use these <strong>@form-element-input__[]</strong> variables by default. Control-specific global variables can be set up separately.<br/><strong>@input-text__[]</strong> is used to set up input-text controls style<br/><strong>@select__[]</strong> is used to set up selects style<br/><strong>@textarea__[]</strong> is used to set up textarea style</td>
</tr>
<tr>
<th>@_background</th>
Expand Down
2 changes: 1 addition & 1 deletion lib/web/css/docs/variables.html
Original file line number Diff line number Diff line change
Expand Up @@ -3507,7 +3507,7 @@ <h4 id="the-codelibformelementinputcoed-mixin-variables">The <code>.lib-form-ele
<th>@_type</th>
<td class="vars_value">@form-element-input-type</td>
<td class="vars_value">'' [input-text | select | textarea | input-radio | input-checkbox]</td>
<td>Form control type.<br/><b>@form-element-input__[]</b> global variables are used to set up all form elements style. Control-specific global variables use these <b>@form-element-input__[]</b> variables by default. Control-specific global variables can be set up separately.<br/><b>@input-text__[]</b> is used to set up input-text controls style<br/><b>@select__[]</b> is used to set up selects style<br/><b>@textarea__[]</b> is used to set up textarea style</td>
<td>Form control type.<br/><strong>@form-element-input__[]</strong> global variables are used to set up all form elements style. Control-specific global variables use these <strong>@form-element-input__[]</strong> variables by default. Control-specific global variables can be set up separately.<br/><strong>@input-text__[]</strong> is used to set up input-text controls style<br/><strong>@select__[]</strong> is used to set up selects style<br/><strong>@textarea__[]</strong> is used to set up textarea style</td>
</tr>
<tr>
<th>@_background</th>
Expand Down
4 changes: 2 additions & 2 deletions setup/view/magento/setup/data-option.phtml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
value="false"
>
<label class="form-label" for="keepData">
<b>Keep data</b>
<strong>Keep data</strong>
<br/><br/>
Note: You can see the associated data in your database,
however your customer will not see this in your online store.
Expand All @@ -59,7 +59,7 @@
value="true"
>
<label class="form-label" for="removeData">
<b>Remove data</b>
<strong>Remove data</strong>
<br/><br/>
Did you back up first? Choosing to remove data means the data is unavailable unless you
recover it from a backup in the preceding step.
Expand Down
7 changes: 5 additions & 2 deletions setup/view/magento/setup/extension-grid.phtml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/

// @codingStandardsIgnoreFile

?>
<h2 class="page-title">{{$state.current.header}}</h2>

Expand Down Expand Up @@ -66,8 +69,8 @@

<div class="row" ng-show="$root.isMarketplaceAuthorized && extensionsProcessed && total == 0">
<label class="form-label not-found">
<b>You haven't purchased any extensions yet. Visit <a href="https://marketplace.magento.com">Marketplace</a>
for purchasing extensions.</b><br/>
<strong>You haven't purchased any extensions yet. Visit <a href="https://marketplace.magento.com">Marketplace</a>
for purchasing extensions.</strong><br/>
</label>
</div>
<div class="admin__data-grid-outer-wrap"
Expand Down
2 changes: 1 addition & 1 deletion setup/view/magento/setup/module-grid.phtml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<div class="row" ng-show="modulesProcessed && total == 0">
<label class="form-label">
<b>We didn't find any modules at this time. Please try later.</b><br/>
<strong>We didn't find any modules at this time. Please try later.</strong><br/>
</label>
</div>
<div class="admin__data-grid-outer-wrap" ng-show="modulesProcessed && total > 0">
Expand Down
2 changes: 1 addition & 1 deletion setup/view/magento/setup/select-version.phtml
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
</div>
<div class="row" ng-show="componentsProcessed && total == 0">
<label class="form-label">
<b>We didn't find any components to upgrade. Click "Next" to continue.<br/>
<strong>We didn't find any components to upgrade. Click "Next" to continue.</strong><br/>
</label>
</div>
<div class="admin__data-grid-outer-wrap" ng-show="componentsProcessed && total > 0">
Expand Down