Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix: SalesQuoteSaveAfterObserver fails to update the checkout session quote id when applicable #19678

Merged

Conversation

dmytro-ch
Copy link
Contributor

Original Pull Request

#19425

Description (*)

The checkout session quote id is not updated due to line 35 in \Magento\Checkout\Observer\SalesQuoteSaveAfterObserver which incorrectly calls $this->checkoutSession->getQuoteId($quote->getId());
In order to update the checkout session quote id, the setQuoteId method should be called.

Fixed Issues (if relevant)

  1. \Magento\Checkout\Observer\SalesQuoteSaveAfterObserver fails to update the checkout session quote id when applicable #19424: "\Magento\Checkout\Observer\SalesQuoteSaveAfterObserver fails to update the checkout session quote id when applicable"

Manual testing scenarios (*)

  1. During the guest checkout, session quote id should be set after dispatching the sales_quote_save_after event.
  2. Verify that the guest checkout is working properly.

Affected functionality

  1. Guest Checkout

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Checkout Release Line: 2.2 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 9, 2018
@dmytro-ch dmytro-ch requested a review from rogyar December 9, 2018 09:46
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Dec 9, 2018
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-3649 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Checkout Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants