Use repository to load order when manually creating an invoice #19727

JeroenVanLeusden · 2018-12-12T14:34:46Z

Description (*)

Use repository to load order when manually creating an invoice. This way extension attributes are set and can be used later in the flow (e.g. observers).

Fixed Issues (if relevant)

None I could find.

Manual testing scenarios (*)

Create extension attribute on Order entity.
Place order and manually capture the invoice.
Order + extension attributes should be loaded but they're not.

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

magento-engcom-team · 2018-12-12T14:34:52Z

Hi @JeroenVanLeusden. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

orlangur · 2018-12-12T15:22:02Z

app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/NewAction.php

     */
    public function __construct(
        Action\Context $context,
        Registry $registry,
        PageFactory $resultPageFactory,
-        InvoiceService $invoiceService
+        InvoiceService $invoiceService,
+        OrderRepositoryInterface $orderRepository


Please inject new dependencies in backward-compatible manner: https://devdocs.magento.com/guides/v2.3/contributor-guide/backward-compatible-development/#adding-a-constructor-parameter

orlangur · 2018-12-12T15:22:16Z

app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/NewAction.php

        $this->invoiceService = $invoiceService;
+        $this->orderRepository = $orderRepository;
+
+        parent::__construct($context);


Please call parent constructor first whenever possible.

JeroenVanLeusden · 2018-12-12T15:28:46Z

@orlangur Updated the PR.

magento-engcom-team · 2018-12-12T15:35:46Z

Hi @orlangur, thank you for the review.
ENGCOM-3679 has been created to process this Pull Request

sidolov · 2019-01-04T22:29:55Z

app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/NewAction.php


        try {
            /** @var \Magento\Sales\Model\Order $order */
-            $order = $this->_objectManager->create(\Magento\Sales\Model\Order::class)->load($orderId);
+            $order = $this->orderRepository->get($orderId);
            if (!$order->getId()) {


This check doesn't make sense anymore because orderRepository will throw an exception in case when order does not exist.

@sidolov I've removed the check.

ENGCOM-3679: Static test fix. ENGCOM-3679: Unit test fix.

magento-engcom-team · 2019-01-16T14:56:30Z

Hi @sidolov, thank you for the review.
ENGCOM-3679 has been created to process this Pull Request

sivaschenko · 2019-03-21T16:59:31Z

@kandy can you please approve the performance degradation introduced by this PR:

Invoice Start (Admin Returns Management) - Another one: 35.6% (mainline = 45 | team = 61) -> DEGRADATION

kandy · 2019-03-21T17:27:50Z

@sivaschenko Degradation on Invoice Start Scenario is approved

magento-engcom-team · 2019-03-21T19:13:44Z

Hi @orlangur, thank you for the review.
ENGCOM-3679 has been created to process this Pull Request

ghost · 2019-03-26T16:55:54Z

Hi @JeroenVanLeusden, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

…nvoice #19727

magento-engcom-team added Component: Sales Release Line: 2.3 Partner: H&O partners-contribution Pull Request is created by Magento Partner labels Dec 12, 2018

orlangur self-assigned this Dec 12, 2018

orlangur requested changes Dec 12, 2018

View reviewed changes

JeroenVanLeusden force-pushed the patch-2 branch from 8376b42 to 9653d67 Compare December 12, 2018 15:28

orlangur approved these changes Dec 12, 2018

View reviewed changes

magento-engcom-team added this to the Release: 2.3.1 milestone Dec 12, 2018

magento-engcom-team added the Progress: accept label Jan 2, 2019

sidolov requested changes Jan 4, 2019

View reviewed changes

sidolov added the Progress: needs update label Jan 4, 2019

magento-engcom-team removed the Progress: needs update label Jan 4, 2019

sidolov added the Progress: needs update label Jan 4, 2019

JeroenVanLeusden force-pushed the patch-2 branch from 9546fc9 to 79ed11e Compare January 7, 2019 10:56

Use repository to load order when manually creating an invoice

3ee104d

ENGCOM-3679: Static test fix. ENGCOM-3679: Unit test fix.

JeroenVanLeusden force-pushed the patch-2 branch from 426d81f to 3ee104d Compare January 7, 2019 11:06

sidolov approved these changes Jan 16, 2019

View reviewed changes

sidolov removed the Progress: needs update label Jan 16, 2019

magento-engcom-team assigned sidolov Jan 16, 2019

Merge remote-tracking branch 'mainline/2.3-develop' into patch-2

981a824

okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019

sidolov removed the Progress: accept label Feb 28, 2019

p-bystritsky assigned p-bystritsky and unassigned p-bystritsky Mar 6, 2019

p-bystritsky self-assigned this Mar 18, 2019

sivaschenko requested a review from kandy March 21, 2019 16:59

orlangur approved these changes Mar 21, 2019

View reviewed changes

ghost added the Progress: accept label Mar 22, 2019

magento-engcom-team merged commit 981a824 into magento:2.3-develop Mar 26, 2019

magento-engcom-team added this to the Release: 2.3.2 milestone Mar 26, 2019

magento-engcom-team pushed a commit that referenced this pull request Mar 26, 2019

ENGCOM-3679: Use repository to load order when manually creating an i…

03748b7

…nvoice #19727

JeroenVanLeusden deleted the patch-2 branch March 27, 2019 08:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use repository to load order when manually creating an invoice #19727

Use repository to load order when manually creating an invoice #19727

JeroenVanLeusden commented Dec 12, 2018

magento-engcom-team commented Dec 12, 2018

orlangur Dec 12, 2018

orlangur Dec 12, 2018

JeroenVanLeusden commented Dec 12, 2018

magento-engcom-team commented Dec 12, 2018

sidolov Jan 4, 2019

JeroenVanLeusden Jan 16, 2019

magento-engcom-team commented Jan 16, 2019

sivaschenko commented Mar 21, 2019

kandy commented Mar 21, 2019

magento-engcom-team commented Mar 21, 2019

ghost commented Mar 26, 2019

Use repository to load order when manually creating an invoice #19727

Use repository to load order when manually creating an invoice #19727

Conversation

JeroenVanLeusden commented Dec 12, 2018

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

magento-engcom-team commented Dec 12, 2018

orlangur Dec 12, 2018

Choose a reason for hiding this comment

orlangur Dec 12, 2018

Choose a reason for hiding this comment

JeroenVanLeusden commented Dec 12, 2018

magento-engcom-team commented Dec 12, 2018

sidolov Jan 4, 2019

Choose a reason for hiding this comment

JeroenVanLeusden Jan 16, 2019

Choose a reason for hiding this comment

magento-engcom-team commented Jan 16, 2019

sivaschenko commented Mar 21, 2019

kandy commented Mar 21, 2019

magento-engcom-team commented Mar 21, 2019

ghost commented Mar 26, 2019