Issue #19609 FIXED #19880
Issue #19609 FIXED #19880
Conversation
| @@ -366,9 +366,12 @@ protected function _initElement( | |||
|
|
|||
| $sharedClass = $this->_getSharedCssClass($field); | |||
| $requiresClass = $this->_getRequiresCssClass($field, $fieldPrefix); | |||
| $isReadOnly = $this->isDefaultFieldReadOnly($path); | |||
There was a problem hiding this comment.
It would be nice to move all the readonly check to a private function
There was a problem hiding this comment.
I have fixed this, moved all checks in private function
| { | ||
| $scope = $this->getScope(); | ||
| $isReadOnly = false; | ||
| if ($scope !== ScopeConfigInterface::SCOPE_TYPE_DEFAULT) { |
There was a problem hiding this comment.
I think this check is unnecessary, $isReadOnly value assigned inside the condition is correct for default scope
There was a problem hiding this comment.
Removed this check.
| $isReadOnly = $this->isDefaultFieldReadOnly($path); | ||
| if (!$isReadOnly) { | ||
| $isReadOnly = $this->getElementVisibility()->isDisabled($field->getPath()) | ||
| ?: $this->getSettingChecker()->isReadOnly($path, $this->getScope(), $this->getStringScopeCode()); |
There was a problem hiding this comment.
Please consider injecting \Magento\Config\Model\Config\Reader\Source\Deployed\SettingCheckeras \Magento\Theme\Model\Design\Config\DataProvider::getSettingChecker method is deprecated
There was a problem hiding this comment.
@sivaschenko do i need to inject \Magento\Config\Model\Config\Reader\Source\Deployed\SettingChecker in constructor?
There was a problem hiding this comment.
Hi @maheshWebkul721 , yes, please
There was a problem hiding this comment.
@sivaschenko added!
|
Hi @maheshWebkul721 please add a new dependency in a backward compatible way, please see the |
|
@sivaschenko added constructor parameter as per contribution guide. |
|
Hi @maheshWebkul721, thank you for your contribution! |
|
Hi @maheshWebkul721. Thank you for your contribution. |
i have preposed a solution to fix #19609 issue, if there is configuration field lock entry available for
default scope then all scopes filed will be readonly.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
php bin/magento config:set --lock-config general/store_information/name "Test lock";bin/magento config:set --scope=stores --scope-code=india --lock-config general/store_information/name "India"Contribution checklist (*)