Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] added config for catalog review in frontend #19943

Merged
merged 4 commits into from
Feb 8, 2019
Merged

[Backport] added config for catalog review in frontend #19943

merged 4 commits into from
Feb 8, 2019

Conversation

torhoehn
Copy link
Contributor

Original Pull Request

#18895

Description

Until now there wasn't a config field to hide product review elements from frontend. I orientated at the wishlist module, because for wishlist it was already possible.

Manual testing scenarios

  1. Open Backend
  2. Go to Stores -> Configuration -> Catalog -> Catalog -> Product Reviews
  3. Set 'Enabled' to 'No'
  4. Newsletter will be hidden from catalog product view, customer account, customer account sidebar, ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@rogyar
Copy link
Contributor

rogyar commented Dec 23, 2018

Hi @torhoehn. Thank you for your collaboration. Please, consider fixing failing unit tests.

@rogyar rogyar self-assigned this Dec 23, 2018
@torhoehn
Copy link
Contributor Author

@rogyar So for PHP 7.0 the return type should be removed?

@rogyar
Copy link
Contributor

rogyar commented Jan 30, 2019

Yes, void return type is supported since PHP 7.1

@torhoehn
Copy link
Contributor Author

torhoehn commented Feb 2, 2019

@rogyar Looks good for me now.

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-4131 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 1b9f91f into magento:2.2-develop Feb 8, 2019
@ghost
Copy link

ghost commented Feb 8, 2019

Hi @torhoehn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@torhoehn torhoehn deleted the 2.2-develop-PR-port-18895 branch February 13, 2019 22:10
@sidolov sidolov added this to the Release: 2.2.9 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants