-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] added config for catalog review in frontend #19943
[Backport] added config for catalog review in frontend #19943
Conversation
Hi @torhoehn. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @torhoehn. Thank you for your collaboration. Please, consider fixing failing unit tests. |
@rogyar So for PHP 7.0 the return type should be removed? |
Yes, void return type is supported since PHP 7.1 |
@rogyar Looks good for me now. |
Hi @rogyar, thank you for the review. |
Hi @torhoehn, thank you for your contribution! |
Original Pull Request
#18895
Description
Until now there wasn't a config field to hide product review elements from frontend. I orientated at the wishlist module, because for wishlist it was already possible.
Manual testing scenarios
Contribution checklist