Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3 develop resolve wrong variable in parameter for phpDoc IN DataBuilder, closes #19974 #19976

Closed
wants to merge 2 commits into from

Conversation

kunj1988
Copy link
Contributor

@kunj1988 kunj1988 commented Dec 26, 2018

Fixed Issue #19974 (if relevant)

  1. Wrong variable in parameter for phpDoc IN DataBuilder #19974: Wrong variable in parameter for phpDoc IN DataBuilder

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 26, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @kunj1988. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@DanielRuf
Copy link
Contributor

Please sign the CLA and update the issue title. 2.3-develop as title is not sufficient.

@VladimirZaets
Copy link
Contributor

Hi @kunj1988, thanks for collaboration. Looks like your branch contains changes that are not related to the fix issue.

@VladimirZaets VladimirZaets self-assigned this Dec 26, 2018
@kunj1988 kunj1988 changed the title 2.3 develop 2.3 develop resolved Wrong variable in parameter for phpDoc IN DataBuilder #19974 Dec 26, 2018
@kunj1988
Copy link
Contributor Author

kunj1988 commented Dec 26, 2018

Please sign the CLA and update the issue title. 2.3-develop as title is not sufficient.

@DanielRuf, I have updated it please review it.

@kunj1988
Copy link
Contributor Author

Hi @kunj1988, thanks for collaboration. Looks like your branch contains changes that are not related to the fix issue.

@VladimirZaets, So do I need to commit it with the new branch?

@DanielRuf DanielRuf changed the title 2.3 develop resolved Wrong variable in parameter for phpDoc IN DataBuilder #19974 2.3 develop resolved Wrong variable in parameter for phpDoc IN DataBuilder, closes #19974 Dec 26, 2018
@DanielRuf DanielRuf changed the title 2.3 develop resolved Wrong variable in parameter for phpDoc IN DataBuilder, closes #19974 2.3 develop resolve wrong variable in parameter for phpDoc IN DataBuilder, closes #19974 Dec 26, 2018
@DanielRuf
Copy link
Contributor

@VladimirZaets which changes do you mean? I think he just used two logins to contribute (shell / bash and GitHub).

@kunj1988 kunj1988 closed this Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants