-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.3] Add support for validation message callback #20079
[2.3] Add support for validation message callback #20079
Conversation
- Adds a type check for message just before attempting to process validation params on it - Resolves the callback if it was one using the validation rule for the 'this' context
Hi @floorz. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
- Change double quotes to single quotes
Hi @VladimirZaets, thank you for the review. |
@VladimirZaets should I make a branch and pull request similar to this but for the 2.2-develop branch? |
Hi @floorz, thank for collaboration. Yes, you are right, but PR to 2.2 branch will be processed after PR for 2.3 will be merged. |
…datorMessageCallback
Hi @floorz, thank you for your contribution! |
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)