Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3] Add support for validation message callback #20079

Conversation

floorz
Copy link
Contributor

@floorz floorz commented Jan 5, 2019

Description (*)

  • Adds a type check for message just before attempting to process validation params on it
  • Resolves the callback if it was one using the validation rule for the 'this' context

Fixed Issues (if relevant)

  1. Magento Ui form validator message callback not supported #20078: Magento Ui form validator message callback not supported

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

- Adds a type check for message just before attempting to process validation params on it
- Resolves the callback if it was one using the validation rule for the 'this' context
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 5, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @floorz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

- Change double quotes to single quotes
@VladimirZaets VladimirZaets self-assigned this Jan 7, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 7, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3803 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@floorz thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@floorz floorz changed the title 20078 Add support for validation message callback Add support for validation message callback Jan 8, 2019
@floorz
Copy link
Contributor Author

floorz commented Jan 8, 2019

@VladimirZaets should I make a branch and pull request similar to this but for the 2.2-develop branch?

@floorz floorz changed the title Add support for validation message callback [2.3] Add support for validation message callback Jan 8, 2019
@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@VladimirZaets
Copy link
Contributor

Hi @floorz, thank for collaboration. Yes, you are right, but PR to 2.2 branch will be processed after PR for 2.3 will be merged.

@ghost
Copy link

ghost commented Mar 5, 2019

Hi @floorz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants