[Backport] issue resolved:Undefined Variable $itemsOrderItemId

[milindsingh]

Original Pull Request

#19941
Fixed Issue #19940 : Exceptio undefined variable itemsOrderItemId while creating shipment through MSI

Description (*)

Fixed Issue #19940 : Exceptio undefined variable itemsOrderItemId while creating shipment through MSI

Fixed Issues (if relevant)

1. Exception undefined variable itemsOrderItemId while creating shipment through MSI #19940: Exception undefined variable itemsOrderItemId while creating shipment through MSI

Manual testing scenarios (*)

1. Login to Admin Panel
2. On left navigation goto Stores-> Inventory->sources
3. Create two source
4. Now goto left navigation Stores-> Inventory->stocks
5. Create stock with Sales Channels : Main website , and add source created above to the stock
6. Go to Catalog->products
7. Click edit button of any products which is type of simple product , now assign two source and add quantity to them, at last save product.
8. repeat step 7 for another product
9. Now goto frontend and place order of above mentioned two products of single quantity each.
10. From admin panel select order and create shipment
11. Ship only one products from first source.
12. Now one product shipped from first source
13. Try to ship that product again.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @milindsingh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[nuzil]

HI @milindsingh
Thanks a lot for your contribution!
Your fix is currently ok as its a backport. But there is a code mess test failed, as its appear in the same file, can you please have a look and if possible apply fix for it?

[milindsingh]

@nuzil yeah sure. I am checking

[milindsingh]

@nuzil I have added the warning suppression as in Magento 2.3. You can review.

[ghost]

Hi @milindsingh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[magento-engcom-team]

Hi @milindsingh. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.