-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error on logo upload for Transactional Emails (#20091) #20092
Conversation
Hi @chaplynsky. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@magento-engcom-team give me test instance |
Hi @davidverholen. Thank you for your request. I'm working on Magento instance for you |
Hi @davidverholen, thank you for the review. |
@chaplynsky thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
@magento-engcom-team give me test instance |
Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you |
Hi @chaplynsky thank you for the contribution. There is an issue on the PR codebase: Steps to reproduce:
Actual Result: Error: "email_logo does not contain field 'file'" |
@sivaschenko, I encounter issues with Select from Gallery elsewhere in the Admin panel, may actually open an Issue for that too... Can you check if this same issue exists in the stock 2.3 codebase? The upload didn't work at all before the change I committed, so this issue may not be caused by the PR codebase. |
@magento-engcom-team give me test instance |
Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you |
@magento-engcom-team give me test instance |
Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you |
Hi @sivaschenko, here is your new Magento instance. |
@magento-engcom-team give me 2.3-develop instance |
Hi @sivaschenko. Thank you for your request. I'm working on Magento 2.3-develop instance for you |
Hi @sivaschenko, here is your Magento instance. |
Hi @chaplynsky thanks for your response. Indeed, this problem affect all imageUploader fields and should be addressed in separate issue. We will process this pull request further. |
The problem with selecting from gallery is reported as a separate issue: #21032 |
@sivaschenko thanks for looking into this. Please let me know why the Travis CI build is failing. I'm not sure how to handle that, because this is my first pull request. |
I've seen this error before, It should not be related to this pr |
@chadbean @davidverholen is right, Travis build fail is not related to the PR |
Hi @chaplynsky, thank you for your contribution! |
Description (*)
Changed "fileUploader" to "imageUploader" on line 16.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)