Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue fixed #20128 : Date range returns the same start and end date #20129

Merged

Conversation

milindsingh
Copy link
Member

@milindsingh milindsingh commented Jan 8, 2019

Description (*)

Date range returns the same start and end date incase custom.

Fixed Issues (if relevant)

  1. Magento\Reports\Model\ResourceModel\Order\Collection->getDateRange() - Error in code? #20128: Magento\Reports\Model\ResourceModel\Order\Collection->getDateRange() - Error in code

Manual testing scenarios (*)

  1. Use of getDateRange() with custom as $range.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @milindsingh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@milindsingh milindsingh changed the title Issue fixed #20123 : Date range returns the same start and end date Issue fixed #20128 : Date range returns the same start and end date Jan 8, 2019
@milindsingh milindsingh force-pushed the 2.3-develop-issue-20128 branch from 80b631a to b1b6c3c Compare January 8, 2019 18:08
@VladimirZaets VladimirZaets self-assigned this Jan 8, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 8, 2019
@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@ghost
Copy link

ghost commented Mar 5, 2019

Hi @milindsingh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants