Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed for Product per row not proper on listing page #20171

Conversation

amol2jcommerce
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Product per row not proper on listing page  #20140: Product per row not proper on listing page
  2. ...

Manual testing scenarios (*)

  1. In any listing page of version 2.3 for all view
  2. Number of product per row not proper

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

Hi @amol2jcommerce thanks for the contribution! Please see the recent pull request #20168 fixing the same issue. Let's close this pull request and collaborate to deliver the earlier one.

@amol2jcommerce
Copy link
Contributor Author

Please see the recent pull request #20168 fixing the same issue. Then close this pull request.

@ghost
Copy link

ghost commented Jan 10, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@amol2jcommerce amol2jcommerce deleted the fixed-Product-per-row-not-proper-on-listing-page branch January 22, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants