Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] 'customer-login-page-input-field-are-short-width-on-tablet-view' :: a… #20173

Conversation

nainesh2jcommerce
Copy link
Contributor

@nainesh2jcommerce nainesh2jcommerce commented Jan 10, 2019

…dd changes for On customer login page input field are short width on tablet view

Original Pull Request

#20369

Description (*)

Fixed Issues (if relevant)

  1. On customer login page input field are short width on tablet view #20172
  2. ...

Manual testing scenarios (*)

  1. go to customer login page
  2. and check input fields in tablet view

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…dd changes for On customer login page input field are short width on tablet view
@magento-engcom-team
Copy link
Contributor

Hi @nainesh2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 10, 2019
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3824 has been created to process this Pull Request

…n customer login page input field are short width on tablet view
@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 17, 2019

Hello @nainesh2jcommerce

During testing our QA engineer faced an issue.
Could you please have a look and fix it?

Please see the quote of QA comment after testing on branch with the PR:
Problem: PR doesn't fix #20172 for Luma theme.

  1. Apply Luma theme.
  2. Apply tablet view
  3. Go to Customer Login Page

Actual Result: not OK, Width of Email and Password fields are short
20173

Thank you for contribution and collaboration!

@nainesh2jcommerce
Copy link
Contributor Author

Hi @sdzhepa
I have already commits changes for Luma Theme yesterday

3f6c2c8

Thanks!

@nainesh2jcommerce
Copy link
Contributor Author

Hi @magento-engcom-team
I have already commits changes for luma theme few days ago
3f6c2c8

Thanks!

@nainesh2jcommerce
Copy link
Contributor Author

Hi @magento-engcom-team,
Is any further update needed from my end?

@nainesh2jcommerce
Copy link
Contributor Author

Hi @VladimirZaets,
Any news on this PR?

@mageprince mageprince changed the title 'customer-login-page-input-field-are-short-width-on-tablet-view' :: a… [Forwardport] 'customer-login-page-input-field-are-short-width-on-tablet-view' :: a… Jan 24, 2019
@magento-engcom-team magento-engcom-team added Partner: Two Jay partners-contribution Pull Request is created by Magento Partner labels Jan 28, 2019
@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
…in-page-input-field-are-short-width-on-tablet-view
@ghost
Copy link

ghost commented Feb 13, 2019

Hi @nainesh2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sidolov sidolov added this to the Release: 2.3.2 milestone Feb 13, 2019
@Nazar65
Copy link
Member

Nazar65 commented Mar 12, 2019

Hi @nainesh2jcommerce, your changes broke login form on blank theme
DeepinScreenshot_select-area_20190312172522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants