Fixed Issue #20121 Cancel order increases stock although "Set Items' Status to be In Stock When Order is Cancelled" is set to No

[shikhamis11]

Fixed Issue #20121 Cancel order increases stock although "Set Items' Status to be In Stock When Order is Cancelled" is set to No

Preconditions

1. Magento 2.2.6 Community
2. Reproduced on PHP 7.1.18 and 7.1.25
3. MariaDB 10.1.26 and 10.3.11
4. Go to Stores -> Configuration -> Catalog -> Inventory and make sure the following options are set as per below:

• Decrease Stock When Order is Placed to Yes
• Set Items' Status to be In Stock When Order is Cancelled to No
• Manage Stock to Yes
• Automatically Return Credit Memo Item to Stock to No
  (see screenshot below)
  

Steps to reproduce

1. Place an order with 1 item of product (i.e. qty = 1)
2. Cancel order

Expected result

1. Product quantity in product catalog is decreased by 1 after order is created
2. Product quantity remains the same (i.e. does not increase) after order is canceled

Actual result

1. Product quantity in product catalog is decreased by 1 after order is created
2. Product quantity is increased by 1 immediately after order is canceled

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @shikhamis11. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-3845 has been created to process this Pull Request

[ghost]

Hi @shikhamis11, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[magento-engcom-team]

Hi @shikhamis11. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

[magento-engcom-team]

Hi @shikhamis11. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.