-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ISSUE-20296: "@magentoDataIsolation" is used instead of "@magentoDbIsolation" in some integration tests. #20298
ISSUE-20296: "@magentoDataIsolation" is used instead of "@magentoDbIsolation" in some integration tests. #20298
Conversation
Hi @p-bystritsky. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@@ -741,7 +741,7 @@ protected function getOptionValues(\Magento\Catalog\Model\Product\Option $option | |||
/** | |||
* Test that product import with images works properly | |||
* | |||
* @magentoDataIsolation enabled | |||
* @magentoDbIsolation enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, it didn't have effect before? Why do we need to enable DB isolation then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@orlangur updated.
…olation" in some integration tests.
30d2732
to
de64b09
Compare
Hi @orlangur, thank you for the review. |
Hi @p-bystritsky, thank you for your contribution! |
Hi @p-bystritsky. Thank you for your contribution. Please, consider to port this solution to 2.3 release line. |
Port to 2.3 is not needed as issue is already fixed in 2.3-develop branch (commit ab4ad4d). |
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
No scenario
Contribution checklist (*)