-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change product_price_value in cart data section based on tax settings #20316
Conversation
Hi @NickdeK. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @josefbehr, thank you for the review. |
Hi @NickdeK, thank you for your contribution! |
Description (*)
Change the
product_price_value
data based on the tax setting. Uses the same functions as used in the template for theproduct_price
data so it should always match the data shown in the minicart. The exception is when both prices should be shown (inclusive and exclusive tax), in this case a object is returned with both prices in it.product_price_value
is not used anywhere in Magento so this shouldn't be a problem.Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)