Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change product_price_value in cart data section based on tax settings #20316

Merged
merged 3 commits into from
Mar 4, 2019
Merged

Conversation

NickdeK
Copy link
Contributor

@NickdeK NickdeK commented Jan 15, 2019

Description (*)

Change the product_price_value data based on the tax setting. Uses the same functions as used in the template for the product_price data so it should always match the data shown in the minicart. The exception is when both prices should be shown (inclusive and exclusive tax), in this case a object is returned with both prices in it. product_price_value is not used anywhere in Magento so this shouldn't be a problem.

Fixed Issues (if relevant)

  1. Cart section data has wrong product_price_value #20310: Cart section data has wrong product_price_value

Manual testing scenarios (*)

  1. Set Magento configuration Stores > Configuration > Sales > Tax > Shopping Cart Display Settings > Display Prices to Including Tax/Excluding Tax/Both
  2. Add a item to your cart
  3. Check the cart data section in dev tools to see if the correct price is shown.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 15, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @NickdeK. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Contributor

Hi @josefbehr, thank you for the review.
ENGCOM-4359 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@NickdeK thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ghost
Copy link

ghost commented Mar 4, 2019

Hi @NickdeK, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants