Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small PHPDocs fixes [Catalog module] #20338

Merged
merged 4 commits into from Jan 23, 2019
Merged

Small PHPDocs fixes [Catalog module] #20338

merged 4 commits into from Jan 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 16, 2019

Description

  • Deleted unused code
  • Small PHPDocs fixes in Catalog module

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @SikailoISM. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Catalog Release Line: 2.3 Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Jan 16, 2019
ghost
ghost commented Jan 16, 2019
View reviewed changes
app/code/Magento/Catalog/Api/CategoryLinkRepositoryInterface.php
@@ -39,7 +39,7 @@ public function delete(\Magento\Catalog\Api\Data\CategoryProductLinkInterface $p
/**
* Remove the product assignment from the category by category id and sku
*
* @param string $categoryId
* @param int $categoryId
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see app/code/Magento/Catalog/Model/CategoryLinkManagement.php:88

@sivaschenko sivaschenko self-assigned this Jan 18, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 18, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-3916 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit e1707be into magento:2.3-develop Jan 23, 2019
@ghost
Copy link

ghost commented Jan 23, 2019

Hi @SikailoISM, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jan 23, 2019
@sidolov
ENGCOM-3916: Small PHPDocs fixes [Catalog module] #20338
1257e63
@magento-engcom-team
Copy link
Contributor

Hi @SikailoISM. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @SikailoISM. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

@ghost ghost deleted the small-catalog-module-fix branch January 24, 2019 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sivaschenko sivaschenko

Labels
Cleanup Component: Catalog Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@magento-engcom-team @sivaschenko @nmalevanec