Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue Fixed: #8086: Multiline admin field is broken #20371

Merged
merged 1 commit into from
Feb 24, 2019
Merged

Issue Fixed: #8086: Multiline admin field is broken #20371

merged 1 commit into from
Feb 24, 2019

Conversation

vivekkumarcedcoss
Copy link
Contributor

@vivekkumarcedcoss vivekkumarcedcoss commented Jan 17, 2019

Description (*)

Fixed Issues (if relevant)

  1. Multiline admin field is broken #8086: Multiline admin field is broken
  2. Multiline field is broken #18115

Manual testing scenarios (*)

  1. Add field type="multiline" in system config in admin.
  2. Save values in multiple fields

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @vivekkumarcedcoss. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@aleron75
Copy link
Contributor

Hello @vivekkumarcedcoss thanks for your contribution.

Once merged, don't forget you can easily port this PR (if needed) to other branches with the Porting Tool, read more here.

@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-3924 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@vivekkumarcedcoss thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@ghost
Copy link

ghost commented Feb 24, 2019

Hi @vivekkumarcedcoss, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants