Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Changes-Schedule-Update-Form-filed-misalign-2.2 #20404

Conversation

amol2jcommerce
Copy link
Contributor

@amol2jcommerce amol2jcommerce commented Jan 18, 2019

Description (*)

Original Issue: #20402

Fixed Issues (if relevant)

  1. Fixed-Schedule-Update-Form-filed-misalign #20403: Schedule update from filed misalignment in 768 x 1147 resolution
  2. Magento 2.2.x

Manual testing scenarios (*)

  1. Login to Admin panel => Catalog => Categories => Navigate any category => Schedule Design Update section
  2. Schedule update from field misalignment in 768 x 1147 resolution

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

sivaschenko commented Jan 18, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, here is your new Magento instance.
Admin access: https://pr-20404.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@sivaschenko
Copy link
Member

Hi @amol2jcommerce thanks for the contribution, can you please port this PR to 2.3-develop branch as we'd like to merge it to 2.3 first to keep branches in sync.

@amol2jcommerce
Copy link
Contributor Author

Hi @sivaschenko ,
Our pull request for 2.2-develop branch same changes are present in the 2.3-develop & pull request is #20403

@amol2jcommerce amol2jcommerce changed the title Changes-Schedule-Update-Form-filed-misalign [Backport] Changes-Schedule-Update-Form-filed-misalign Jan 29, 2019
@amol2jcommerce amol2jcommerce changed the title [Backport] Changes-Schedule-Update-Form-filed-misalign [Backport] Changes-Schedule-Update-Form-filed-misalign-2.2 Jan 30, 2019
@amol2jcommerce
Copy link
Contributor Author

Hi @sivaschenko @magento-engcom-team please review.

@sivaschenko sivaschenko self-assigned this Feb 13, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-4245 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 13, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants