Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] 'wishlist-page-edit-remove-item-misalign-2-2' :: On wish list page ed… #20406

Conversation

nainesh2jcommerce
Copy link
Contributor

@nainesh2jcommerce nainesh2jcommerce commented Jan 18, 2019

…it, remove item misalign in 640 X 767 resolution

Description (*)

Original PR: #20400

Fixed Issues (if relevant)

  1. On wish list page edit, remove item misalign in 640 X 767 resolution #20399: : On wish list page edit, remove item misalign in 640 X 767 resolution

Manual testing scenarios (*)

  1. add product to wish list
  2. check edit remove item button on 640 X 767 resolution

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…it, remove item misalign in 640 X 767 resolution
@magento-engcom-team
Copy link
Contributor

Hi @nainesh2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@nainesh2jcommerce
Copy link
Contributor Author

Hi @rogyar,
Any news on this PR? Thanks!

@rogyar rogyar changed the title 'wishlist-page-edit-remove-item-misalign-2-2' :: On wish list page ed… [Backport] 'wishlist-page-edit-remove-item-misalign-2-2' :: On wish list page ed… Jan 28, 2019
@magento-engcom-team magento-engcom-team added Partner: Two Jay partners-contribution Pull Request is created by Magento Partner labels Jan 28, 2019
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-3911 has been created to process this Pull Request

@okorshenko okorshenko removed this from the Release: 2.2.8 milestone Jan 28, 2019
@sdzhepa
Copy link
Contributor

sdzhepa commented Jan 31, 2019

Hello @nainesh2jcommerce

We found that issue was already fixed and delivered in the scope of #20544

This PR can be closed.

Thank you for contribution and collaboration!

@sdzhepa sdzhepa closed this Jan 31, 2019
@ghost
Copy link

ghost commented Jan 31, 2019

Hi @nainesh2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants