Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Changes-Hamburger-Icon-was-available-on-a-page #20417

Closed
wants to merge 1 commit into from
Closed

[Forwardport] Changes-Hamburger-Icon-was-available-on-a-page #20417

wants to merge 1 commit into from

Conversation

GovindaSharma
Copy link
Contributor

Original Pull Request

#20219

Description (*)

Fixed Issues (if relevant)

  1. Hamburger Icon was available on a page where menu was not present. Issue in responsive view #20210: Hamburger Icon was available on a page where menu was not present. Issue in responsive view
  2. Magento version 2.2

Manual testing scenarios (*)

  1. Login to Customer Panel
  2. Place Order for any product
  3. Create invoice and shipment for this order from the backend
  4. Repeat step 1
  5. Open the browser in mobile responsive
  6. Go to my account->my order->view the same order or any other order with the status "complete"
  7. Click on Order Shipment subtab
  8. Click on Print All Shipments
  9. Cancel the option to print the Shipment form
  10. Check the page

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @GovindaSharma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

Hi @GovindaSharma thanks for the pull request!

The fix was already ported by the author of the original pull request. Here is the PR to 2.3: #20214

Closing this pull request as duplicate, please reach me in case of any questions or comments.

@ghost
Copy link

ghost commented Jan 21, 2019

Hi @GovindaSharma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants