Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Unnecessary slash in namespace in di.xml #20425

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Removed Unnecessary slash in namespace in di.xml #20425

merged 1 commit into from
Jan 23, 2019

Conversation

milindsingh
Copy link
Member

@milindsingh milindsingh commented Jan 20, 2019

Description (*)

Removed unnecessary root slash \ in namespace in di.xml causing failure in overwriting with same namespace without root slash. Hence, removed all root slashes from di.xml where present.

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @milindsingh. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@aleron75 aleron75 self-assigned this Jan 21, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 21, 2019
@magento-engcom-team
Copy link
Contributor

Hi @aleron75, thank you for the review.
ENGCOM-3923 has been created to process this Pull Request

@aleron75
Copy link
Contributor

Hello @milind

@aleron75
Copy link
Contributor

Hello @milindsingh thanks for your contribution.

Once merged, don't forget you can easily port this PR (if needed) to other branches with the Porting Tool, read more here.

@milindsingh
Copy link
Member Author

milindsingh commented Jan 21, 2019

@aleron75 Sure! Thanks!
(Also, SSL for Magento Porting Tool has expired, making it unavailable for web (chrome & firefox))
https://porting.engcom.dev.magento.com/login
https porting engcom dev magento com login

@magento-engcom-team magento-engcom-team merged commit 989b0b1 into magento:2.3-develop Jan 23, 2019
@ghost
Copy link

ghost commented Jan 23, 2019

Hi @milindsingh, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team
Copy link
Contributor

Hi @milindsingh. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

1 similar comment
@magento-engcom-team
Copy link
Contributor

Hi @milindsingh. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment