Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in _resets.less #20499

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Fix typo in _resets.less #20499

merged 1 commit into from
Feb 13, 2019

Conversation

sjaakvdbrom
Copy link
Contributor

Change Resetes to Resets

Description (*)

This fixes a typo made in a First level comment in _resets.less.

Manual testing scenarios (*)

  1. ...
  2. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sjaakvdbrom
Fix typo in _resets.less
a3b1d34 
Change Resetes to Resets
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jan 23, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @sjaakvdbrom. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets VladimirZaets self-assigned this Jan 23, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.1 milestone Jan 23, 2019
@okorshenko okorshenko removed this from the Release: 2.3.1 milestone Jan 28, 2019
@magento-engcom-team magento-engcom-team merged commit a3b1d34 into magento:2.3-develop Feb 13, 2019
@ghost
Copy link

ghost commented Feb 13, 2019

Hi @sjaakvdbrom, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Feb 13, 2019
@sidolov
ENGCOM-3950: Fix typo in _resets.less #20499
0ab44d0
@sidolov sidolov added this to the Release: 2.3.2 milestone Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@VladimirZaets VladimirZaets

Labels
Area: Lib/Frontend Cleanup Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.2
Development

Successfully merging this pull request may close these issues.
6 participants
@sjaakvdbrom @magento-cicd2 @magento-engcom-team @VladimirZaets @okorshenko @sidolov