Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fixed-Widget-left-navigation-block-2.2 #20529

Conversation

amol2jcommerce
Copy link
Contributor

@amol2jcommerce amol2jcommerce commented Jan 23, 2019

Description (*)

Original Issue: #20492

Fixed Issues (if relevant)

  1. Widget-left-navigation-block #20493: In Admin configuration Widget left navigation block not proper in tablet landscape view
  2. Magento 2.2

Manual testing scenarios (*)

  1. Admin configuration CONTENT->Widget->Add new widget
  2. While filling form ,left navigation block have design issue in tablet view

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @amol2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@VladimirZaets
Copy link
Contributor

Hi @amol2jcommerce. Please note that changes to 2.2-develop branch can be accepted only if these changes are present in the 2.3-develop branch (https://devdocs.magento.com/guides/v2.2/contributor-guide/contributing.html). Please, create a pull request to the 2.3-develop branch and rename this one as backport.

@VladimirZaets VladimirZaets self-assigned this Jan 23, 2019
@amol2jcommerce amol2jcommerce changed the title Fixed-Widget-left-navigation-block-2.2 [Backport] Fixed-Widget-left-navigation-block-2.2 Jan 23, 2019
@amol2jcommerce
Copy link
Contributor Author

Hi @VladimirZaets ,
Our pull request for 2.2-develop branch and 2.3-develop pull request is #20493

@amol2jcommerce
Copy link
Contributor Author

Hi @VladimirZaets @magento-engcom-team please review.

@VladimirZaets
Copy link
Contributor

Hi @amol2jcommerce. Why code in this PR is different from the original PR?

@amol2jcommerce
Copy link
Contributor Author

Hi @VladimirZaets branch updated. please review.

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-4247 has been created to process this Pull Request

@ghost
Copy link

ghost commented Feb 14, 2019

Hi @amol2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants