Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes-customer-information-wishlist-configurable-product-alignment #20558

Conversation

priti2jcommerce
Copy link
Contributor

@priti2jcommerce priti2jcommerce commented Jan 24, 2019

Description (*)

admin customer information wishlist configurable product alignment issue while editing
Magento 2.3.0

Fixed Issues (if relevant)

  1. Admin Customer configuraion in whishlist associated product for configurable product misalign #20760
  2. ...

Manual testing scenarios (*)

  1. Go to admin
  2. In Customers >>All customers>> edit customer>>click on wishlist
  3. Action Configure

Expected result (*)

2019-01-24_11-44_p d - customers - customers

Actual result (*)

2019-01-24_11-42_p d - customers - customers

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@priti2jcommerce
Copy link
Contributor Author

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @priti2jcommerce. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@federivo
Copy link
Member

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @federivo. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @federivo, here is your Magento instance.
Admin access: https://i-20558-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@federivo federivo self-assigned this Jan 30, 2019
@magento-engcom-team
Copy link
Contributor

Hi @federivo, thank you for the review.
ENGCOM-4053 has been created to process this Pull Request

@federivo
Copy link
Member

@priti2jcommerce thank you for your contribution.
When merged, consider back-porting this to 2.2. You can easily achieve it using the Porting Tool, check here.

@priti2jcommerce
Copy link
Contributor Author

Hi @federivo ,

Thanks for update

@ghost
Copy link

ghost commented Feb 12, 2019

Hi @priti2jcommerce, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants