Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #20631 Fixed. #20632

Closed
wants to merge 0 commits into from
Closed

Issue #20631 Fixed. #20632

wants to merge 0 commits into from

Conversation

mahesh-rajawat
Copy link
Member

@mahesh-rajawat mahesh-rajawat commented Jan 26, 2019 •
edited by novikor
Loading

Fixed checkout shipping page issue #20631

Description (*)

Console error on checkout after changing the allowed countries from admin.

Fixed Issues (if relevant)

  1. Console error on checkout after changing the allowed countries from admin. #20631
  2. ...

Manual testing scenarios (*)

  1. Add a product to cart as guest.
  2. Fill the shipping address and reload the page now shipping address must be filled already.
  3. Go to Admin->Stores->configuration->General, Change allowed countries single one that is not filled on checkout. like i have filled United State at checkout and change allowed countries to Libya.
  4. Now reload the checkout shipping page again.

Now there is no console error.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@novikor novikor requested review from swnsma and novikor January 26, 2019 12:56
novikor
novikor requested changes Jan 26, 2019
View reviewed changes
Copy link
Contributor

@novikor novikor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maheshWebkul721 , please squash your commits (merge with 2.3 and fix inself) into one.
Also please create a port of this Pull Request for 2.2-develop.

Thank you.

@ghost
Copy link

ghost commented Jan 26, 2019

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mahesh-rajawat mahesh-rajawat force-pushed the shipping-address-checkout branch from 7e12cd6 to 35c4f04 Compare January 26, 2019 14:28
@mahesh-rajawat
Copy link
Member Author

@novikor, i tried to sqash all commits but not able to do it, could you please suggest me some commands, so i can create a new PR. i think i made some mistake with this PR

@mahesh-rajawat mahesh-rajawat mentioned this pull request Jan 26, 2019
Closed
4 tasks
@swnsma swnsma removed their request for review February 3, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novikor novikor novikor requested changes

Assignees
No one assigned
Labels
Area: Frontend Component: Ui Progress: needs update Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mahesh-rajawat @magento-engcom-team @novikor