Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] issue #18349 Fixed for 2.3: Incorrect quote_item_id saved on order items during multiple address checkout #20650

Conversation

mahesh-rajawat
Copy link
Member

Original Pull Request

#19192

Incorrect quote_item_id saved on order items during multiple address checkout issue fixed.

Description (*)

When order placed using Multiple address checkout then there were incorrect quote_item_id in
sales_order_item table.

Fixed Issues (if relevant)

  1. Incorrect quote_item_id saved on order items during multiple address checkout #18349

Manual testing scenarios (*)

  1. Placed and Order with Multi address checkout, now quote_item_id is correct.
  2. Placed an order with Onestep checkout quote_item_id is correct as well.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@amol2jcommerce
Copy link
Contributor

Hi @maheshWebkul721 PR already created #20640

@milindsingh
Copy link
Member

Hi @maheshWebkul721 PR already created #20640

@amol2jcommerce I would suggest to the Magento Porting Tool for creating backports and reference the original PR if possible.
Thanks

@sivaschenko
Copy link
Member

Thanks for the port @maheshWebkul721 , however, let's collaborate to deliver earlier port PR. Closing this pull request as a duplicate to #20640

@ghost
Copy link

ghost commented Jan 27, 2019

Hi @maheshWebkul721, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sivaschenko sivaschenko self-assigned this Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants